Re: [PBDS] Rejuvenation

[Jonathan Wakely <jwakely@redhat.com>]

On 24/07/19 13:18 +0100, Jonathan Wakely wrote:
>On Wed, 24 Jul 2019 at 12:58, Tadeus Prastowo <tadeus.prastowo@unitn.it> wrote:
>>
>> Hi Alex,
>>
>> As Jonathan suggested in
>> https://gcc.gnu.org/ml/libstdc++/2019-07/msg00066.html, what do you
>> think if we start with: "regenerate the graphs in the documentation
>> that show poor binary heap performance, as mentioned in
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62045"?
>
>Sounds good to me. The data in those graphs are produced by the tests
>in testsuite/performance/ext/pb_ds/*.cc but I'm not sure how the XML
>output of those tests is turned into the PDF and PNG files that are
>included in doc/xml/manual/test_policy_data_structures.xml (and it
>doesn't help that the filenames listed in the docs are wrong, e.g. the
>docs say:
>
>      <para>
>        It uses the test file:
>        <filename>performance/ext/pb_ds/priority_queue_random_int_push_timing.cc</filename>
>      </para>
>
>but actually that should be performance/ext/pb_ds/priority_queue_int_push.cc
>
>You can find the right test file names by grepping in the
>testsuite/performance/ext/pb_ds/ directory for the name in the docs,
>because the test files contain the same name as used in the docs (it
>just doesn't match the actual filename):
>
>master% libstdc++-v3$ git grep priority_queue_random_int_push_timing
>testsuite/performance/ext/pb_ds/
>testsuite/performance/ext/pb_ds/priority_queue_int_push.cc: * @file
>priority_queue_random_int_push_timing_test.cpp
>testsuite/performance/ext/pb_ds/priority_queue_int_push.cc:  cerr <<
>"usage: priority_queue_random_int_push_timing_test <vn> <vs> <vm>" <<
>master% libstdc++-v3$ git grep
>priority_queue_random_int_push_pop_timing
>testsuite/performance/ext/pb_ds/
>testsuite/performance/ext/pb_ds/priority_queue_int_push_pop.cc: *
>@file priority_queue_random_int_push_pop_timing_test.cpp
>testsuite/performance/ext/pb_ds/priority_queue_int_push_pop.cc:
>std::cerr << "usage: priority_queue_random_int_push_pop_timing_test
><vn> <vs> <vm>" <<

That would be easier to read without gmail's auto-wrapping:

master% libstdc++-v3$ git grep priority_queue_random_int_push_timing testsuite/performance/ext/pb_ds/
testsuite/performance/ext/pb_ds/priority_queue_int_push.cc: * @file priority_queue_random_int_push_timing_test.cpp
testsuite/performance/ext/pb_ds/priority_queue_int_push.cc:  cerr << "usage: priority_queue_random_int_push_timing_test <vn> <vs> <vm>" <<
master% libstdc++-v3$ git grep priority_queue_random_int_push_pop_timing testsuite/performance/ext/pb_ds/
testsuite/performance/ext/pb_ds/priority_queue_int_push_pop.cc: * @file priority_queue_random_int_push_pop_timing_test.cpp
testsuite/performance/ext/pb_ds/priority_queue_int_push_pop.cc:  std::cerr << "usage: priority_queue_random_int_push_pop_timing_test <vn> <vs> <vm>" <<