public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] Remove broken URL from libstdc++ manual
@ 2019-09-05  7:45 Jonathan Wakely
  2019-10-07 18:55 ` Thomas Schwinge
  0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Wakely @ 2019-09-05  7:45 UTC (permalink / raw)
  To: libstdc++, gcc-patches; +Cc: Marek Polacek, Gerald Pfeifer

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

The URL for the "What Are Allocators Good For?" article has been a
recurring source of problems. It moved from the C/C++ Users Journal
website to the Dr Dobbs site after CUJ shut down, and the original
domain changed hands, leaving old links pointing to nefarious sites.

Now the URL to the copy on drdobbs.com no longer works either and I
can't find a (legal) copy of the article online. The simplest solution
is to remove the URL.

	* doc/xml/manual/allocator.xml: Remove URL for bibliography entry.
	* doc/html/*: Regenerate.

Committed to trunk. I think I'll backport this too, so we don't keep a
non-working link in the docs on release branches.



[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 1609 bytes --]

commit 45a605e970ea6db474e40c02aef6b18993fea05c
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu Sep 5 08:40:35 2019 +0100

    Remove broken URL from libstdc++ manual
    
    The URL for the "What Are Allocators Good For?" article has been a
    recurring source of problems. It moved from the C/C++ Users Journal
    website to the Dr Dobbs site after CUJ shut down, and the original
    domain changed hands, leaving old links pointing to nefarious sites.
    
    Now the URL to the copy on drdobbs.com no longer works either and I
    can't find a (legal) copy of the article online. The simplest solution
    is to remove the URL.
    
            * doc/xml/manual/allocator.xml: Remove URL for bibliography entry.
            * doc/html/*: Regenerate.

diff --git a/libstdc++-v3/doc/xml/manual/allocator.xml b/libstdc++-v3/doc/xml/manual/allocator.xml
index 0de1be9465a..922bc49091c 100644
--- a/libstdc++-v3/doc/xml/manual/allocator.xml
+++ b/libstdc++-v3/doc/xml/manual/allocator.xml
@@ -482,12 +482,9 @@
   </biblioentry>
 
   <biblioentry>
-      <title>
-	<link xmlns:xlink="http://www.w3.org/1999/xlink"
-	      xlink:href="http://www.drdobbs.com/the-standard-librarian-what-are-allocato/184403759">
+    <title>
       The Standard Librarian: What Are Allocators Good For?
-	</link>
-      </title>
+    </title>
 
     <author><personname><firstname>Matt</firstname><surname>Austern</surname></personname></author>
     <publisher>
@@ -495,6 +492,7 @@
 	C/C++ Users Journal
       </publishername>
     </publisher>
+    <pubdate>2000-12</pubdate>
   </biblioentry>
 
   <biblioentry>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Remove broken URL from libstdc++ manual
  2019-09-05  7:45 [PATCH] Remove broken URL from libstdc++ manual Jonathan Wakely
@ 2019-10-07 18:55 ` Thomas Schwinge
  2019-10-08 10:42   ` Jonathan Wakely
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Schwinge @ 2019-10-07 18:55 UTC (permalink / raw)
  To: Jonathan Wakely; +Cc: Marek Polacek, Gerald Pfeifer, libstdc++, gcc-patches

[-- Attachment #1: Type: text/plain, Size: 2285 bytes --]

Hi!

On 2019-09-05T08:45:50+0100, Jonathan Wakely <jwakely@redhat.com> wrote:
> Committed to trunk. I think I'll backport this too, so we don't keep a
> non-working link in the docs on release branches.

> commit 45a605e970ea6db474e40c02aef6b18993fea05c
> Author: Jonathan Wakely <jwakely@redhat.com>
> Date:   Thu Sep 5 08:40:35 2019 +0100
>
>     Remove broken URL from libstdc++ manual
>     
>     The URL for the "What Are Allocators Good For?" article has been a
>     recurring source of problems. It moved from the C/C++ Users Journal
>     website to the Dr Dobbs site after CUJ shut down, and the original
>     domain changed hands, leaving old links pointing to nefarious sites.
>     
>     Now the URL to the copy on drdobbs.com no longer works either and I
>     can't find a (legal) copy of the article online. The simplest solution
>     is to remove the URL.
>     
>             * doc/xml/manual/allocator.xml: Remove URL for bibliography entry.
>             * doc/html/*: Regenerate.
>
> diff --git a/libstdc++-v3/doc/xml/manual/allocator.xml b/libstdc++-v3/doc/xml/manual/allocator.xml
> index 0de1be9465a..922bc49091c 100644
> --- a/libstdc++-v3/doc/xml/manual/allocator.xml
> +++ b/libstdc++-v3/doc/xml/manual/allocator.xml
> @@ -482,12 +482,9 @@
>    </biblioentry>
>  
>    <biblioentry>
> -      <title>
> -	<link xmlns:xlink="http://www.w3.org/1999/xlink"
> -	      xlink:href="http://www.drdobbs.com/the-standard-librarian-what-are-allocato/184403759">

For what it's worth: see
<https://web.archive.org/web/*/http://www.drdobbs.com/the-standard-librarian-what-are-allocato/184403759>,
and
<https://web.archive.org/web/20190622154249/http://www.drdobbs.com/the-standard-librarian-what-are-allocato/184403759>
seems to be the latest revision they've got.


Grüße
 Thomas


> +    <title>
>        The Standard Librarian: What Are Allocators Good For?
> -	</link>
> -      </title>
> +    </title>
>  
>      <author><personname><firstname>Matt</firstname><surname>Austern</surname></personname></author>
>      <publisher>
> @@ -495,6 +492,7 @@
>  	C/C++ Users Journal
>        </publishername>
>      </publisher>
> +    <pubdate>2000-12</pubdate>
>    </biblioentry>
>  
>    <biblioentry>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 658 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Remove broken URL from libstdc++ manual
  2019-10-07 18:55 ` Thomas Schwinge
@ 2019-10-08 10:42   ` Jonathan Wakely
  0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Wakely @ 2019-10-08 10:42 UTC (permalink / raw)
  To: Thomas Schwinge; +Cc: Marek Polacek, Gerald Pfeifer, libstdc++, gcc-patches

[-- Attachment #1: Type: text/plain, Size: 1914 bytes --]

On 07/10/19 20:54 +0200, Thomas Schwinge wrote:
>Hi!
>
>On 2019-09-05T08:45:50+0100, Jonathan Wakely <jwakely@redhat.com> wrote:
>> Committed to trunk. I think I'll backport this too, so we don't keep a
>> non-working link in the docs on release branches.
>
>> commit 45a605e970ea6db474e40c02aef6b18993fea05c
>> Author: Jonathan Wakely <jwakely@redhat.com>
>> Date:   Thu Sep 5 08:40:35 2019 +0100
>>
>>     Remove broken URL from libstdc++ manual
>>
>>     The URL for the "What Are Allocators Good For?" article has been a
>>     recurring source of problems. It moved from the C/C++ Users Journal
>>     website to the Dr Dobbs site after CUJ shut down, and the original
>>     domain changed hands, leaving old links pointing to nefarious sites.
>>
>>     Now the URL to the copy on drdobbs.com no longer works either and I
>>     can't find a (legal) copy of the article online. The simplest solution
>>     is to remove the URL.
>>
>>             * doc/xml/manual/allocator.xml: Remove URL for bibliography entry.
>>             * doc/html/*: Regenerate.
>>
>> diff --git a/libstdc++-v3/doc/xml/manual/allocator.xml b/libstdc++-v3/doc/xml/manual/allocator.xml
>> index 0de1be9465a..922bc49091c 100644
>> --- a/libstdc++-v3/doc/xml/manual/allocator.xml
>> +++ b/libstdc++-v3/doc/xml/manual/allocator.xml
>> @@ -482,12 +482,9 @@
>>    </biblioentry>
>>
>>    <biblioentry>
>> -      <title>
>> -	<link xmlns:xlink="http://www.w3.org/1999/xlink"
>> -	      xlink:href="http://www.drdobbs.com/the-standard-librarian-what-are-allocato/184403759">
>
>For what it's worth: see
><https://web.archive.org/web/*/http://www.drdobbs.com/the-standard-librarian-what-are-allocato/184403759>,
>and
><https://web.archive.org/web/20190622154249/http://www.drdobbs.com/the-standard-librarian-what-are-allocato/184403759>
>seems to be the latest revision they've got.

Good idea, thanks!

I've committed this patch to trunk.



[-- Attachment #2: patch.txt --]
[-- Type: text/x-patch, Size: 1120 bytes --]

commit 9bc329fa19e859ba535e1ebbefab83b96accf4b9
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Oct 8 11:10:08 2019 +0100

    Restore URL for Austern article on allocators
    
    This reverts "Remove broken URL from libstdc++ manual" by restoring the
    link, but using an archived copy from the Wayback Machine.
    
            * doc/xml/manual/allocator.xml: Use archived copy of CUJ article.
            * doc/html/*: Regenerate.

diff --git a/libstdc++-v3/doc/xml/manual/allocator.xml b/libstdc++-v3/doc/xml/manual/allocator.xml
index 922bc49091c..d8a255ca213 100644
--- a/libstdc++-v3/doc/xml/manual/allocator.xml
+++ b/libstdc++-v3/doc/xml/manual/allocator.xml
@@ -483,7 +483,10 @@
 
   <biblioentry>
     <title>
+      <link xmlns:xlink="http://www.w3.org/1999/xlink"
+	    xlink:href="https://web.archive.org/web/20190622154249/http://www.drdobbs.com/the-standard-librarian-what-are-allocato/184403759">
       The Standard Librarian: What Are Allocators Good For?
+      </link>
     </title>
 
     <author><personname><firstname>Matt</firstname><surname>Austern</surname></personname></author>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-10-08 10:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-05  7:45 [PATCH] Remove broken URL from libstdc++ manual Jonathan Wakely
2019-10-07 18:55 ` Thomas Schwinge
2019-10-08 10:42   ` Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).