From: Jonathan Wakely <jwakely@redhat.com>
To: JeanHeyd Meneide <phdofthehouse@gmail.com>
Cc: Jakub Jelinek <jakub@redhat.com>,
gcc-patches@gcc.gnu.org, libstdc++ <libstdc++@gcc.gnu.org>
Subject: Re: [ PATCH ] [ C++ ] [ libstdc++ ] P1208r6 Merge source_location
Date: Thu, 02 Jan 2020 10:28:00 -0000 [thread overview]
Message-ID: <20200102102822.GL40198@redhat.com> (raw)
In-Reply-To: <CANHA4Ohhgv2-cF0Q-r0Y1UfM5Wo=12dFj_PrQKMQtS0VLdP5OQ@mail.gmail.com>
On 27/12/19 22:27 -0500, JeanHeyd Meneide wrote:
>On Fri, Dec 27, 2019 at 2:33 PM Jakub Jelinek <jakub@redhat.com> wrote:
>>
>> This will be ABI incompatible between GCC and Clang, that doesn't look like
>> a good idea to me. I thought the plan is to use what you have in the
>> _GLIBCXX_HAVE_BUILTIN_SOURCE_LOCATION case always, except that if
>> __builtin_source_location isn't available, initialize _M_data to nullptr.
>
>You're right, it's probably bad to have an implementation that
>switches. I guess that means clang folks will have to implement the
>builtin too at some point (but Jonathan's comment in the
>__builtin_source_location patch said they might not, so I'm not sure
>what to do for Clang here I guess?).
Do nothing - compiling with Clang won't define std::source_location at
all.
next prev parent reply other threads:[~2020-01-02 10:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-27 19:27 JeanHeyd Meneide
2019-12-27 19:33 ` Jakub Jelinek
2019-12-28 3:28 ` JeanHeyd Meneide
2020-01-02 10:28 ` Jonathan Wakely [this message]
2020-01-02 21:57 ` JeanHeyd Meneide
2020-01-02 22:07 ` Jakub Jelinek
2020-01-02 22:21 ` JeanHeyd Meneide
2020-12-03 19:25 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200102102822.GL40198@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=libstdc++@gcc.gnu.org \
--cc=phdofthehouse@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).