From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: copy/copy_backward/fill/fill_n/equal rework
Date: Fri, 10 Jan 2020 15:27:00 -0000 [thread overview]
Message-ID: <20200110152136.GD490107@redhat.com> (raw)
In-Reply-To: <20191210151932.GR11522@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 611 bytes --]
On 10/12/19 15:19 +0000, Jonathan Wakely wrote:
>On 09/12/19 10:32 +0100, François Dumont wrote:
>>After completing this work and running more tests I realized that
>>the declaration of algos was still not ideal.
>>
>>So here is another version where algos are not re-declare in
>>stl_deque.h, I rather include stl_algobase.h in deque.tcc. The
>>problem was spotted but another patch I am going to submit
>>afterward.
>
>OK for trunk (with a suitable ChangeLog).
>
>Thanks for persisting with this, sorry it took so long.
A small fix for C++98 compat, I'll commit this to trunk shortly.
[-- Attachment #2: patch.txt --]
[-- Type: text/x-patch, Size: 901 bytes --]
commit a9b209bd8032a36ad0a02d15358e5c5d699df9fa
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Fri Jan 10 15:02:07 2020 +0000
libstdc++: Fix testcase for C++98 compatibility
* testsuite/25_algorithms/equal/deque_iterators/1.cc: Don't use C++11
initialization syntax.
diff --git a/libstdc++-v3/testsuite/25_algorithms/equal/deque_iterators/1.cc b/libstdc++-v3/testsuite/25_algorithms/equal/deque_iterators/1.cc
index be60db813cc..82bef051542 100644
--- a/libstdc++-v3/testsuite/25_algorithms/equal/deque_iterators/1.cc
+++ b/libstdc++-v3/testsuite/25_algorithms/equal/deque_iterators/1.cc
@@ -104,7 +104,7 @@ void test05()
{
using namespace std;
- int a[] { 0, 1, 2, 3, 4 };
+ int a[] = { 0, 1, 2, 3, 4 };
deque<int, __gnu_cxx::new_allocator<int> > d1(a, a + 5);
deque<int, __gnu_cxx::malloc_allocator<int> > d2(a, a + 5);
next prev parent reply other threads:[~2020-01-10 15:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 18:34 François Dumont
2019-09-25 4:45 ` François Dumont
2019-12-09 9:32 ` François Dumont
2019-12-10 15:19 ` Jonathan Wakely
2020-01-10 15:27 ` Jonathan Wakely [this message]
2019-09-27 12:28 ` Jonathan Wakely
2019-09-27 21:14 ` François Dumont
2019-10-09 4:56 ` François Dumont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110152136.GD490107@redhat.com \
--to=jwakely@redhat.com \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).