From: Jonathan Wakely <jwakely@redhat.com>
To: Thomas Rodgers <trodgers@redhat.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
"libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] Suppress deprecation warnings in tbb effective target check
Date: Fri, 24 Jan 2020 17:21:00 -0000 [thread overview]
Message-ID: <20200124105252.GB2969@redhat.com> (raw)
In-Reply-To: <xkqetv4lfl7t.fsf@trodgers.remote.f30>
You didn't provide a ChangeLog entry. Please be sure to add one.
OK for master and gcc-9 branch, with the ChangeLog entry. Thanks.
On 23/01/20 21:59 -0800, Thomas Rodgers wrote:
>TBB 2020 added deprecation warnings which produced output not expected by
>check_effective_target_tbb-backend
>---
> libstdc++-v3/testsuite/lib/libstdc++.exp | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/libstdc++-v3/testsuite/lib/libstdc++.exp b/libstdc++-v3/testsuite/lib/libstdc++.exp
>index 94f3fdb2bc8..f451719bdd4 100644
>--- a/libstdc++-v3/testsuite/lib/libstdc++.exp
>+++ b/libstdc++-v3/testsuite/lib/libstdc++.exp
>@@ -1597,7 +1597,8 @@ proc check_effective_target_tbb-backend { } {
> puts $f "}"
> close $f
>
>- set lines [v3_target_compile $src $exe executable "additional_flags=-std=c++17 additional_flags=-ltbb"]
>+ set lines [v3_target_compile $src $exe executable "additional_flags=-std=c++17 additional_flags=-ltbb
>+ additional_flags=-DTBB_SUPPRESS_DEPRECATED_MESSAGES=1"]
> file delete $src
>
> if [string match "" $lines] {
>--
>2.21.1
>
prev parent reply other threads:[~2020-01-24 10:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 10:52 Thomas Rodgers
2020-01-24 17:21 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124105252.GB2969@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=trodgers@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).