From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 8FC90393FC2F for ; Thu, 12 Mar 2020 10:13:12 +0000 (GMT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-446-fD6BXsllP5KgCRNxBSmktw-1; Thu, 12 Mar 2020 06:13:08 -0400 X-MC-Unique: fD6BXsllP5KgCRNxBSmktw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 442CC801E5C; Thu, 12 Mar 2020 10:13:07 +0000 (UTC) Received: from localhost (unknown [10.33.36.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id D615B5D9C5; Thu, 12 Mar 2020 10:13:06 +0000 (UTC) Date: Thu, 12 Mar 2020 10:13:06 +0000 From: Jonathan Wakely To: Fangrui Song Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH] libstdc++: Fix the return type of __cxa_finalize according to the Itanium C++ ABI Message-ID: <20200312101306.GC9441@redhat.com> References: <20200312042430.td6cwfxv3oj6vguy@google.com> MIME-Version: 1.0 In-Reply-To: <20200312042430.td6cwfxv3oj6vguy@google.com> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Spam-Status: No, score=-27.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2020 10:13:14 -0000 Please CC libstdc++@gcc.gnu.org for all libstdc++ patches, as per https://gcc.gnu.org/lists.html On 11/03/20 21:24 -0700, Fangrui Song wrote: >Alternatively, we can delete it, because no user code should call it. >It may be weird that libc is expected to define this function. >This function is a language runtime interface that has nothing to do >with a libc. It's coupled with __cxa_atexit, and the ABI says: "It is expected that implementations supporting both C and C++ will integrate this capability into the libc atexit implementation so that C-only DSOs will nevertheless interact with C++ programs in a C++-standard-conforming manner." >--- > libstdc++-v3/libsupc++/cxxabi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/libstdc++-v3/libsupc++/cxxabi.h b/libstdc++-v3/libsupc++/cxxa= bi.h >index 50298205daa..000713ecdf8 100644 >--- a/libstdc++-v3/libsupc++/cxxabi.h >+++ b/libstdc++-v3/libsupc++/cxxabi.h >@@ -127,7 +127,7 @@ namespace __cxxabiv1 > int > __cxa_atexit(void (*)(void*), void*, void*) _GLIBCXX_NOTHROW; > >- int >+ void > __cxa_finalize(void*); The change is correct, but I think we should wait for stage 1 (after the GCC 10 release) to apply it. If I forget, please remind us in a couple of months.