* Re: [PATCH] libstdc++: Fix the return type of __cxa_finalize according to the Itanium C++ ABI [not found] <20200312042430.td6cwfxv3oj6vguy@google.com> @ 2020-03-12 10:13 ` Jonathan Wakely 2020-05-04 22:24 ` Jonathan Wakely 0 siblings, 1 reply; 2+ messages in thread From: Jonathan Wakely @ 2020-03-12 10:13 UTC (permalink / raw) To: Fangrui Song; +Cc: gcc-patches, libstdc++ Please CC libstdc++@gcc.gnu.org for all libstdc++ patches, as per https://gcc.gnu.org/lists.html On 11/03/20 21:24 -0700, Fangrui Song wrote: >Alternatively, we can delete it, because no user code should call it. >It may be weird that libc is expected to define this function. >This function is a language runtime interface that has nothing to do >with a libc. It's coupled with __cxa_atexit, and the ABI says: "It is expected that implementations supporting both C and C++ will integrate this capability into the libc atexit implementation so that C-only DSOs will nevertheless interact with C++ programs in a C++-standard-conforming manner." >--- > libstdc++-v3/libsupc++/cxxabi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/libstdc++-v3/libsupc++/cxxabi.h b/libstdc++-v3/libsupc++/cxxabi.h >index 50298205daa..000713ecdf8 100644 >--- a/libstdc++-v3/libsupc++/cxxabi.h >+++ b/libstdc++-v3/libsupc++/cxxabi.h >@@ -127,7 +127,7 @@ namespace __cxxabiv1 > int > __cxa_atexit(void (*)(void*), void*, void*) _GLIBCXX_NOTHROW; > >- int >+ void > __cxa_finalize(void*); The change is correct, but I think we should wait for stage 1 (after the GCC 10 release) to apply it. If I forget, please remind us in a couple of months. ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libstdc++: Fix the return type of __cxa_finalize according to the Itanium C++ ABI 2020-03-12 10:13 ` [PATCH] libstdc++: Fix the return type of __cxa_finalize according to the Itanium C++ ABI Jonathan Wakely @ 2020-05-04 22:24 ` Jonathan Wakely 0 siblings, 0 replies; 2+ messages in thread From: Jonathan Wakely @ 2020-05-04 22:24 UTC (permalink / raw) To: Fangrui Song, libstdc++, gcc-patches On 12/03/20 10:13 +0000, Jonathan Wakely via Libstdc++ wrote: >Please CC libstdc++@gcc.gnu.org for all libstdc++ patches, as per >https://gcc.gnu.org/lists.html > >On 11/03/20 21:24 -0700, Fangrui Song wrote: >>Alternatively, we can delete it, because no user code should call it. >>It may be weird that libc is expected to define this function. >>This function is a language runtime interface that has nothing to do >>with a libc. > >It's coupled with __cxa_atexit, and the ABI says: > >"It is expected that implementations supporting both C and C++ will >integrate this capability into the libc atexit implementation so that >C-only DSOs will nevertheless interact with C++ programs in a >C++-standard-conforming manner." > >>--- >>libstdc++-v3/libsupc++/cxxabi.h | 2 +- >>1 file changed, 1 insertion(+), 1 deletion(-) >> >>diff --git a/libstdc++-v3/libsupc++/cxxabi.h b/libstdc++-v3/libsupc++/cxxabi.h >>index 50298205daa..000713ecdf8 100644 >>--- a/libstdc++-v3/libsupc++/cxxabi.h >>+++ b/libstdc++-v3/libsupc++/cxxabi.h >>@@ -127,7 +127,7 @@ namespace __cxxabiv1 >> int >> __cxa_atexit(void (*)(void*), void*, void*) _GLIBCXX_NOTHROW; >> >>- int >>+ void >> __cxa_finalize(void*); > >The change is correct, but I think we should wait for stage 1 (after >the GCC 10 release) to apply it. If I forget, please remind us in a >couple of months. I've pushed this change to the master branch now. Thanks for the fix. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-04 22:24 UTC | newest] Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20200312042430.td6cwfxv3oj6vguy@google.com> 2020-03-12 10:13 ` [PATCH] libstdc++: Fix the return type of __cxa_finalize according to the Itanium C++ ABI Jonathan Wakely 2020-05-04 22:24 ` Jonathan Wakely
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).