From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id E55A73840C23 for ; Fri, 19 Jun 2020 11:50:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E55A73840C23 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-487-caDDFVNkOg-iaJuVGE2zcQ-1; Fri, 19 Jun 2020 07:50:23 -0400 X-MC-Unique: caDDFVNkOg-iaJuVGE2zcQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CB62C835B41; Fri, 19 Jun 2020 11:50:22 +0000 (UTC) Received: from localhost (unknown [10.33.36.10]) by smtp.corp.redhat.com (Postfix) with ESMTP id 62304709D7; Fri, 19 Jun 2020 11:50:22 +0000 (UTC) Date: Fri, 19 Jun 2020 12:50:21 +0100 From: Jonathan Wakely To: Marc Glisse Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: std::optional defaut constructor Message-ID: <20200619115021.GZ4137376@redhat.com> References: <20200604134625.GE4137376@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200604134625.GE4137376@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-16.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2020 11:50:26 -0000 On 04/06/20 14:46 +0100, Jonathan Wakely wrote: >On 04/06/20 00:50 +0200, Marc Glisse wrote: >>(I don't currently have a setup that would enable me to commit anything. I'll >>try to fix it eventually, but likely not so soon) > >Ah, I missed this bit. I'll take care of it for you. > >If it's due to the Git conversion let me know if it's something I can >help with off-list. > > >>diff --git a/libstdc++-v3/include/std/optional b/libstdc++-v3/include/std/optional >>index 37c2ba7a025..e84ba28a806 100644 >>--- a/libstdc++-v3/include/std/optional >>+++ b/libstdc++-v3/include/std/optional >>@@ -688,7 +688,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION >> public: >> using value_type = _Tp; >> >>- constexpr optional() = default; >>+ constexpr optional() noexcept { } >> >> constexpr optional(nullopt_t) noexcept { } >> Committed to master as r11-1552 bafd12cb22e83b7da8946873513a897e48e2900f