From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 2C7433858D35 for ; Mon, 6 Jul 2020 21:05:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2C7433858D35 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-191-pes_Yl_mMF2V2aQDCUZWVA-1; Mon, 06 Jul 2020 17:05:53 -0400 X-MC-Unique: pes_Yl_mMF2V2aQDCUZWVA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5FB031005510; Mon, 6 Jul 2020 21:05:52 +0000 (UTC) Received: from localhost (unknown [10.33.36.181]) by smtp.corp.redhat.com (Postfix) with ESMTP id DDE6C7788A; Mon, 6 Jul 2020 21:05:51 +0000 (UTC) Date: Mon, 6 Jul 2020 22:05:51 +0100 From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [committed 1/3] libstdc++: Add noexcept to std::optional initialization (PR 96036) Message-ID: <20200706210551.GA750840@redhat.com> MIME-Version: 1.0 X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="Dxnq1zWXvFF0Q93v" Content-Disposition: inline X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jul 2020 21:05:58 -0000 --Dxnq1zWXvFF0Q93v Content-Type: text/plain; charset=us-ascii Content-Disposition: inline libstdc++-v3/ChangeLog: PR libstdc++/96036 * include/std/optional (optional): Add noexcept-specifier to every constructor, assignment operator, emplace function and dereference operator. * testsuite/20_util/optional/assignment/noexcept.cc: New test. * testsuite/20_util/optional/cons/noexcept.cc: New test. Tested powerpc64le-linux, committed to trunk. --Dxnq1zWXvFF0Q93v Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="patch.txt" commit 8992cd1892df1adb352cf5d5b279a00686d1e88a Author: Jonathan Wakely Date: Mon Jul 6 21:54:12 2020 +0100 libstdc++: Add noexcept to std::optional initialization (PR 96036) libstdc++-v3/ChangeLog: PR libstdc++/96036 * include/std/optional (optional): Add noexcept-specifier to every constructor, assignment operator, emplace function and dereference operator. * testsuite/20_util/optional/assignment/noexcept.cc: New test. * testsuite/20_util/optional/cons/noexcept.cc: New test. diff --git a/libstdc++-v3/include/std/optional b/libstdc++-v3/include/std/optional index 923d45ae0e8..785c434412d 100644 --- a/libstdc++-v3/include/std/optional +++ b/libstdc++-v3/include/std/optional @@ -698,6 +698,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION is_convertible<_Up&&, _Tp>> = true> constexpr optional(_Up&& __t) + noexcept(is_nothrow_constructible_v<_Tp, _Up>) : _Base(std::in_place, std::forward<_Up>(__t)) { } template>> = false> explicit constexpr optional(_Up&& __t) + noexcept(is_nothrow_constructible_v<_Tp, _Up>) : _Base(std::in_place, std::forward<_Up>(__t)) { } template>> = true> constexpr optional(const optional<_Up>& __t) + noexcept(is_nothrow_constructible_v<_Tp, const _Up&>) { if (__t) emplace(*__t); @@ -727,6 +730,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION __not_<__converts_from_optional<_Tp, _Up>>> = false> explicit constexpr optional(const optional<_Up>& __t) + noexcept(is_nothrow_constructible_v<_Tp, const _Up&>) { if (__t) emplace(*__t); @@ -739,6 +743,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION __not_<__converts_from_optional<_Tp, _Up>>> = true> constexpr optional(optional<_Up>&& __t) + noexcept(is_nothrow_constructible_v<_Tp, _Up>) { if (__t) emplace(std::move(*__t)); @@ -751,6 +756,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION __not_<__converts_from_optional<_Tp, _Up>>> = false> explicit constexpr optional(optional<_Up>&& __t) + noexcept(is_nothrow_constructible_v<_Tp, _Up>) { if (__t) emplace(std::move(*__t)); @@ -760,6 +766,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION _Requires> = false> explicit constexpr optional(in_place_t, _Args&&... __args) + noexcept(is_nothrow_constructible_v<_Tp, _Args...>) : _Base(std::in_place, std::forward<_Args>(__args)...) { } template> = false> explicit constexpr optional(in_place_t, initializer_list<_Up> __il, _Args&&... __args) + noexcept(is_nothrow_constructible_v<_Tp, initializer_list<_Up>&, + _Args...>) : _Base(std::in_place, __il, std::forward<_Args>(__args)...) { } + // Assignment operators. optional& operator=(nullopt_t) noexcept @@ -786,6 +796,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION is_assignable<_Tp&, _Up>>, optional&> operator=(_Up&& __u) + noexcept(__and_v, + is_nothrow_assignable<_Tp&, _Up>>) { if (this->_M_is_engaged()) this->_M_get() = std::forward<_Up>(__u); @@ -803,6 +815,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION __not_<__assigns_from_optional<_Tp, _Up>>>, optional&> operator=(const optional<_Up>& __u) + noexcept(__and_v, + is_nothrow_assignable<_Tp&, const _Up&>>) { if (__u) { @@ -826,6 +840,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION __not_<__assigns_from_optional<_Tp, _Up>>>, optional&> operator=(optional<_Up>&& __u) + noexcept(__and_v, + is_nothrow_assignable<_Tp&, _Up>>) { if (__u) { @@ -845,6 +861,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION template enable_if_t, _Tp&> emplace(_Args&&... __args) + noexcept(is_nothrow_constructible_v<_Tp, _Args...>) { this->_M_reset(); this->_M_construct(std::forward<_Args>(__args)...); @@ -855,6 +872,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION enable_if_t&, _Args&&...>, _Tp&> emplace(initializer_list<_Up> __il, _Args&&... __args) + noexcept(is_nothrow_constructible_v<_Tp, initializer_list<_Up>&, + _Args...>) { this->_M_reset(); this->_M_construct(__il, std::forward<_Args>(__args)...); @@ -887,27 +906,27 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION // Observers. constexpr const _Tp* - operator->() const + operator->() const noexcept { return std::__addressof(this->_M_get()); } constexpr _Tp* - operator->() + operator->() noexcept { return std::__addressof(this->_M_get()); } constexpr const _Tp& - operator*() const& + operator*() const& noexcept { return this->_M_get(); } constexpr _Tp& - operator*()& + operator*()& noexcept { return this->_M_get(); } constexpr _Tp&& - operator*()&& + operator*()&& noexcept { return std::move(this->_M_get()); } constexpr const _Tp&& - operator*() const&& + operator*() const&& noexcept { return std::move(this->_M_get()); } constexpr explicit operator bool() const noexcept diff --git a/libstdc++-v3/testsuite/20_util/optional/assignment/noexcept.cc b/libstdc++-v3/testsuite/20_util/optional/assignment/noexcept.cc new file mode 100644 index 00000000000..45592b2a18c --- /dev/null +++ b/libstdc++-v3/testsuite/20_util/optional/assignment/noexcept.cc @@ -0,0 +1,81 @@ +// Copyright (C) 2020 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// . + +// { dg-do compile { target c++17 } } + +#include + +template +struct X +{ + X() noexcept(B); + + X(const X&) noexcept(B); + X& operator=(const X&) noexcept(B); + + X(int) noexcept(B); + X& operator=(int) noexcept(false); + + X(void*) noexcept(true); + X& operator=(void*) noexcept(B); + + X(const X&) noexcept(B); + X& operator=(const X&) noexcept(B); + + X(std::initializer_list, int) noexcept(B); +}; + +using std::is_nothrow_assignable_v; + +using Xyes = X; +using Xno = X; +using Oyes = std::optional; +using Ono = std::optional; + +static_assert( is_nothrow_assignable_v ); +static_assert( is_nothrow_assignable_v ); +static_assert( is_nothrow_assignable_v ); +static_assert( ! is_nothrow_assignable_v ); +static_assert( is_nothrow_assignable_v ); +static_assert( is_nothrow_assignable_v ); +static_assert( is_nothrow_assignable_v ); + +static_assert( is_nothrow_assignable_v ); +static_assert( ! is_nothrow_assignable_v ); +static_assert( ! is_nothrow_assignable_v ); +static_assert( ! is_nothrow_assignable_v ); +static_assert( ! is_nothrow_assignable_v ); +static_assert( ! is_nothrow_assignable_v ); +static_assert( ! is_nothrow_assignable_v ); + +Xyes xyes; +Xno xno; +Oyes oyes; +Ono ono; +static_assert( noexcept(oyes.emplace()) ); +static_assert( noexcept(oyes.emplace(xyes)) ); +static_assert( noexcept(oyes.emplace(1)) ); +static_assert( noexcept(oyes.emplace(nullptr)) ); +static_assert( noexcept(oyes.emplace(xno)) ); +static_assert( noexcept(oyes.emplace({1,2,3}, 1)) ); + +static_assert( ! noexcept(ono.emplace()) ); +static_assert( ! noexcept(ono.emplace(xno)) ); +static_assert( ! noexcept(ono.emplace(1)) ); +static_assert( noexcept(ono.emplace(nullptr)) ); +static_assert( ! noexcept(ono.emplace(xyes)) ); +static_assert( ! noexcept(ono.emplace({1,2,3}, 1)) ); diff --git a/libstdc++-v3/testsuite/20_util/optional/cons/noexcept.cc b/libstdc++-v3/testsuite/20_util/optional/cons/noexcept.cc new file mode 100644 index 00000000000..a529f5d39ad --- /dev/null +++ b/libstdc++-v3/testsuite/20_util/optional/cons/noexcept.cc @@ -0,0 +1,64 @@ +// Copyright (C) 2020 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// . + +// { dg-do compile { target c++17 } } + +#include + +template +struct X +{ + X() noexcept(B); + X(const X&) noexcept(B); + + X(int) noexcept(B); + X(std::initializer_list, int) noexcept(B); + + X(const X&) noexcept(B); + + X& operator=(const X&) noexcept(false); +}; + +using std::is_nothrow_constructible_v; +using std::in_place_t; + +using Xyes = X; +using Xno = X; +using Oyes = std::optional; +using Ono = std::optional; + +static_assert( is_nothrow_constructible_v ); +static_assert( is_nothrow_constructible_v ); +static_assert( is_nothrow_constructible_v ); +static_assert( is_nothrow_constructible_v ); +static_assert( is_nothrow_constructible_v ); +static_assert( is_nothrow_constructible_v, + long> ); +static_assert( is_nothrow_constructible_v ); +static_assert( is_nothrow_constructible_v ); + +static_assert( is_nothrow_constructible_v ); +static_assert( is_nothrow_constructible_v ); +static_assert( ! is_nothrow_constructible_v ); +static_assert( ! is_nothrow_constructible_v ); +static_assert( ! is_nothrow_constructible_v ); +static_assert( ! is_nothrow_constructible_v, + long> ); +static_assert( ! is_nothrow_constructible_v ); +static_assert( ! is_nothrow_constructible_v ); --Dxnq1zWXvFF0Q93v--