public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters
Date: Thu, 6 Aug 2020 10:27:39 +0100	[thread overview]
Message-ID: <20200806092739.GS3400@redhat.com> (raw)
In-Reply-To: <8280a7d0-975d-c2e8-b6c2-0149314d9ca2@gmail.com>

On 06/08/20 08:35 +0200, François Dumont wrote:
>On 17/07/20 1:35 pm, Jonathan Wakely wrote:
>>I really like the general idea of getting rid of some of the
>>complexity and not supporting infinite customization. But we can do
>>that without changing mangled names of the _Hashtable specialiations.
>>
>>
>I didn't thought we need to keep abi compatibility for extensions.

These aren't extensions though, they're part of std::unordered_map
etc.

Just because something like _Vector_base is an internal type rather
than something defined in the standard doesn't mean we can just change
its ABI, because that would change the ABI of std::vector. It the same
here.

Changing _Hashtable affects all users of std::unordered_map etc.



  reply	other threads:[~2020-08-06  9:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-17 21:15 François Dumont
2019-11-17 22:21 ` Ville Voutilainen
2019-11-18 21:41   ` François Dumont
2019-11-18 22:10     ` Ville Voutilainen
2020-07-17 10:51       ` Jonathan Wakely
2019-12-19 19:22 ` François Dumont
2020-07-17 11:35   ` Jonathan Wakely
2020-08-06  6:35     ` François Dumont
2020-08-06  9:27       ` Jonathan Wakely [this message]
2020-08-17 17:13         ` François Dumont
2020-08-25 14:30           ` Jonathan Wakely
2020-08-26 15:30             ` Jonathan Wakely
2020-08-26 15:55               ` Jonathan Wakely
2020-08-26 15:58                 ` Jonathan Wakely
2020-08-26 16:45                   ` Jonathan Wakely
2020-08-26 20:37                     ` François Dumont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200806092739.GS3400@redhat.com \
    --to=jwakely@redhat.com \
    --cc=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).