From: Jonathan Wakely <jwakely@redhat.com>
To: "Krystian Kuźniarek" <krystian.kuzniarek@gmail.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: add parentheses around assignments used as truth values
Date: Thu, 10 Sep 2020 16:54:01 +0100 [thread overview]
Message-ID: <20200910155401.GG6061@redhat.com> (raw)
In-Reply-To: <CAHqJ0wHm17CaT3aUXgHmB5bdqBEJpLqfH9RCFTL=uG9VPaPivQ@mail.gmail.com>
On 24/08/20 13:26 +0200, Krystian Kuźniarek via Libstdc++ wrote:
>Hi,
>
>A description of the problem/bug and how your patch addresses it:
>I've got a small patch for -Wparentheses in system headers.
Thanks, I'll commit this one too.
>Testcases:
>N/A, it's only a warning.
>
>ChangeLog:
>Sorry, contrib/mklog.py didn't quite work for me.
>For some reason after instruction in line 129: "diff = PatchSet(data)" my
>"diff" variable is always empty.
>
>Bootstrapping and testing:
>Tested that manually by recompling GCC, unfolding all headers with
>`#include <stdc++.h>` and compiling what's been included by it.
>
>The patch itself:
>diff --git a/libstdc++-v3/include/c_global/cmath
>b/libstdc++-v3/include/c_global/cmath
>index b99aaf8df40..25080511722 100644
>--- a/libstdc++-v3/include/c_global/cmath
>+++ b/libstdc++-v3/include/c_global/cmath
>@@ -1893,7 +1893,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
> constexpr _Fp
> __lerp(_Fp __a, _Fp __b, _Fp __t) noexcept
> {
>- if (__a <= 0 && __b >= 0 || __a >= 0 && __b <= 0)
>+ if ((__a <= 0 && __b >= 0) || (__a >= 0 && __b <= 0))
> return __t * __b + (1 - __t) * __a;
>
> if (__t == 1)
>@@ -1902,7 +1902,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
> // Exact at __t=0, monotonic except near __t=1,
> // bounded, determinate, and consistent:
> const _Fp __x = __a + __t * (__b - __a);
>- return __t > 1 == __b > __a
>+ return (__t > 1) == (__b > __a)
> ? (__b < __x ? __x : __b)
> : (__b > __x ? __x : __b); // monotonic near __t=1
> }
>
>
>Best regards,
>Krystian
>
prev parent reply other threads:[~2020-09-10 15:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 11:26 Krystian Kuźniarek
2020-09-10 15:54 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910155401.GG6061@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=krystian.kuzniarek@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).