From: Jonathan Wakely <jwakely@redhat.com>
To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [committed] libstdc++: Pass CXXFLAGS to check_performance script
Date: Fri, 9 Oct 2020 14:09:28 +0100 [thread overview]
Message-ID: <20201009130928.GP7004@redhat.com> (raw)
In-Reply-To: <20201009130221.GA696194@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 537 bytes --]
On 09/10/20 14:02 +0100, Jonathan Wakely wrote:
>It looks like our check-performance target runs completely unoptimized,
>which is a bit silly. This exports the CXXFLAGS from the parent make
>process to the check_performance script.
>
>libstdc++-v3/ChangeLog:
>
> * scripts/check_performance: Use gnu++11 instead of gnu++0x.
> * testsuite/Makefile.am (check-performance): Export CXXFLAGS to
> child process.
> * testsuite/Makefile.in: Regenerate.
A small adjustment to that last patch.
Tested powerpc64le-linux. Committed to trunk.
[-- Attachment #2: patch.txt --]
[-- Type: text/x-patch, Size: 1101 bytes --]
commit 6ce2cb116af6e0965ff0dd69e7fd1925cf5dc68c
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Fri Oct 9 14:07:22 2020
libstdc++: Adjust variable export in makefile
We usually export variables in recipes this way. I'm not sure it's
necessary, but it's consistent.
libstdc++-v3/ChangeLog:
* testsuite/Makefile.am: Set and export variable separately.
* testsuite/Makefile.in: Regenerate.
diff --git a/libstdc++-v3/testsuite/Makefile.am b/libstdc++-v3/testsuite/Makefile.am
index 2fca179fca4..7b412411bfe 100644
--- a/libstdc++-v3/testsuite/Makefile.am
+++ b/libstdc++-v3/testsuite/Makefile.am
@@ -182,7 +182,7 @@ check-compile: testsuite_files ${compile_script}
check_performance_script=${glibcxx_srcdir}/scripts/check_performance
check-performance: testsuite_files_performance ${performance_script}
-@(chmod + ${check_performance_script}; \
- export CXXFLAGS="$(CXXFLAGS)"; \
+ CXXFLAGS='$(CXXFLAGS)'; export CXXFLAGS; \
${check_performance_script} ${glibcxx_srcdir} ${glibcxx_builddir})
# Runs the testsuite in debug mode.
prev parent reply other threads:[~2020-10-09 13:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 13:02 Jonathan Wakely
2020-10-09 13:09 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009130928.GP7004@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).