From: Jonathan Wakely <jwakely@redhat.com>
To: Patrick Palka <ppalka@redhat.com>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Fix division by zero in std::sample
Date: Tue, 20 Oct 2020 18:02:39 +0100 [thread overview]
Message-ID: <20201020170239.GA954627@redhat.com> (raw)
In-Reply-To: <20200921150134.GE449323@redhat.com>
On 21/09/20 16:01 +0100, Jonathan Wakely wrote:
>On 18/09/20 21:08 -0400, Patrick Palka via Libstdc++ wrote:
>>This fixes a division by zero in the selection-sampling std::__search
>>overload when the input range is empty (and hence __unsampled_sz is 0).
>>
>>Tested on x86_64-pc-linux-gnu.
>>
>>libstdc++-v3/ChangeLog:
>>
>> * include/bits/stl_algo.h (__sample): Exit early when the
>> input range is empty.
>> * testsuite/25_algorithms/sample/3.cc: New test.
>>---
>>libstdc++-v3/include/bits/stl_algo.h | 3 ++
>>.../testsuite/25_algorithms/sample/3.cc | 50 +++++++++++++++++++
>>2 files changed, 53 insertions(+)
>>create mode 100644 libstdc++-v3/testsuite/25_algorithms/sample/3.cc
>
>OK, thanks.
Could you please backport this to all branches too.
next prev parent reply other threads:[~2020-10-20 17:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-19 1:08 [PATCH] libstdc++: Mark some more algorithms constexpr for C++20 Patrick Palka
2020-09-19 1:08 ` [PATCH] libstdc++: Fix division by zero in std::sample Patrick Palka
2020-09-21 12:46 ` Patrick Palka
2020-09-21 15:01 ` Jonathan Wakely
2020-10-20 17:02 ` Jonathan Wakely [this message]
2020-10-20 17:36 ` Patrick Palka
2020-09-21 14:52 ` [PATCH] libstdc++: Mark some more algorithms constexpr for C++20 Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201020170239.GA954627@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).