From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 3A36438708BC for ; Mon, 2 Nov 2020 14:17:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3A36438708BC Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-378-8z7O7FK9OpamltIrcsiR7Q-1; Mon, 02 Nov 2020 09:17:38 -0500 X-MC-Unique: 8z7O7FK9OpamltIrcsiR7Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8899D6415C; Mon, 2 Nov 2020 14:17:36 +0000 (UTC) Received: from localhost (unknown [10.33.36.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id E09DF6CE4E; Mon, 2 Nov 2020 14:17:35 +0000 (UTC) Date: Mon, 2 Nov 2020 14:17:35 +0000 From: Jonathan Wakely To: =?iso-8859-1?Q?Fran=E7ois?= Dumont Cc: "libstdc++@gcc.gnu.org" , gcc-patches Subject: Re: [PATCH] Add missing gnu-versioned-namespace symbols Message-ID: <20201102141735.GS503596@redhat.com> References: MIME-Version: 1.0 In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2020 14:17:44 -0000 On 01/11/20 20:48 +0100, François Dumont via Libstdc++ wrote: >Several tests are failing because of those missing symbols. > >I understand why we need to export symbols relying in the versioned >namespace but I don't understand why we need to do it for >_GLIBCXX_DEBUG symbols which are not version namespace dependant. If you don't export the symbol, it can't be found by code linking to libstdc++.so.8 This linker script is the only one used to build libstdc++.so.8 so all symbols that need to be exported by that library have to be exported by this script. Nothing exports that debug symbol unless you add it here. What I don't understand is why the __istream_extract symbol isn't matched by the wildcard in the extern "C++" block at the top of the file. >Do you want to backport the Debug symbol ? > >    libstdc++: Add mising gnu-versioned-namespace symbols > >    libstdc++-v3/ChangeLog: > >            * config/abi/pre/gnu-versioned-namespace.ver: >            Add __istream_extract and >_Safe_local_iterator_base::_M_attach_single >            symbols. > >Tested under Linux x86_64 versioned namespace. > >Ok to commit ? > >François > >diff --git a/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver b/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver >index 0965854fbc3..3b6d7944d06 100644 >--- a/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver >+++ b/libstdc++-v3/config/abi/pre/gnu-versioned-namespace.ver >@@ -98,6 +98,9 @@ GLIBCXX_8.0 { > _ZNSt3__817__copy_streambufsI*; > _ZNSt3__821__copy_streambufs_eofI*; > >+ # std::__istream_extract(wistream&, wchar_t*, streamsize) >+ _ZNSt3__817__istream_extractIwNS_11char_traitsIwEEEEvRNS_13basic_istreamIT_T0_EEPS4_[ilx]; >+ > # __gnu_cxx::__atomic_add > # __gnu_cxx::__exchange_and_add > _ZN9__gnu_cxx3__812__atomic_addEPV[il][il]; >@@ -145,6 +148,7 @@ GLIBCXX_8.0 { > _ZN11__gnu_debug30_Safe_unordered_container_base13_M_detach_allEv; > _ZN11__gnu_debug25_Safe_local_iterator_base9_M_attachEPNS_19_Safe_sequence_baseEb; > _ZN11__gnu_debug25_Safe_local_iterator_base9_M_detachEv; >+ _ZN11__gnu_debug25_Safe_local_iterator_base16_M_attach_singleEPNS_19_Safe_sequence_baseEb; > > # parallel mode > _ZN14__gnu_parallel9_Settings3getEv;