public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: JonY <10walls@gmail.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>,
	libstdc++ <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: use lt_host_flags for libstdc++.la
Date: Tue, 3 Nov 2020 08:24:48 +0000	[thread overview]
Message-ID: <20201103082448.GU503596@redhat.com> (raw)
In-Reply-To: <38552260-93d1-f6a8-8eba-cb050e95b918@gmail.com>

On 16/09/20 13:16 +0000, JonY via Libstdc++ wrote:
>For platforms like Mingw and Cygwin, cygwin refuses to generate the
>shared library without using -no-undefined.
>
>Attached patch makes sure the right flags are used, since libtool is
>already used to link libstdc++.
>
>Patch OK?

I've pushed it to trunk myself now. Thanks.


From 4ba039687182fccd67e1170f89e259e1c4a58eeb Mon Sep 17 00:00:00 2001
>From: Jonathan Yong <10walls@gmail.com>
>Date: Sun, 22 Mar 2020 09:56:58 +0800
>Subject: [PATCH 1/1] libstdc++: use lt_host_flags for libstdc++.la
>
>Signed-off-by: Jonathan Yong <10walls@gmail.com>
>---
> libstdc++-v3/src/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/libstdc++-v3/src/Makefile.am b/libstdc++-v3/src/Makefile.am
>index a139adc81b3..498f533f3d3 100644
>--- a/libstdc++-v3/src/Makefile.am
>+++ b/libstdc++-v3/src/Makefile.am
>@@ -107,7 +107,7 @@ libstdc___la_DEPENDENCIES = \
> libstdc___la_LDFLAGS = \
> 	-version-info $(libtool_VERSION) ${version_arg} -lm
> 
>-libstdc___la_LINK = $(CXXLINK) $(libstdc___la_LDFLAGS)
>+libstdc___la_LINK = $(CXXLINK) $(libstdc___la_LDFLAGS) $(lt_host_flags)
> 
> # Use special rules for compatibility-ldbl.cc compilation, as we need to
> # pass -mlong-double-64.
>-- 
>2.11.4.GIT
>





      parent reply	other threads:[~2020-11-03  8:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16 13:16 JonY
2020-10-20  2:03 ` Jonathan Yong
2020-11-03  0:36   ` Jonathan Yong
2020-11-03  8:24 ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201103082448.GU503596@redhat.com \
    --to=jwakely@redhat.com \
    --cc=10walls@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).