public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Add missing gnu-versioned-namespace symbols
Date: Tue, 3 Nov 2020 08:25:42 +0000	[thread overview]
Message-ID: <20201103082542.GV503596@redhat.com> (raw)
In-Reply-To: <9c81c091-497e-2e36-a855-ce88fc91fdf9@gmail.com>

On 02/11/20 21:52 +0100, François Dumont via Libstdc++ wrote:
>On 02/11/20 3:17 pm, Jonathan Wakely wrote:
>>On 01/11/20 20:48 +0100, François Dumont via Libstdc++ wrote:
>>>Several tests are failing because of those missing symbols.
>>>
>>>I understand why we need to export symbols relying in the 
>>>versioned namespace but I don't understand why we need to do it 
>>>for _GLIBCXX_DEBUG symbols which are not version namespace 
>>>dependant.
>>
>>If you don't export the symbol, it can't be found by code linking to
>>libstdc++.so.8
>
>So I understand that in versioned namespace mode only 
>gnu-versioned-namespace.ver is being used and not gnu.ver.

Right.

>>
>>This linker script is the only one used to build libstdc++.so.8 so all
>>symbols that need to be exported by that library have to be exported
>>by this script. Nothing exports that debug symbol unless you add it
>>here.
>>
>>What I don't understand is why the __istream_extract symbol isn't
>>matched by the wildcard in the extern "C++" block at the top of the
>>file.
>
>Maybe for the same reason that the std::__copy_streambufs before this 
>one and some others symbols in std::__8 had to be explicitely exported 
>too.
>
>But I don't know it.

Yeah, I don't understand those either.

OK for trunk anyway. I'll investigate another day.



      reply	other threads:[~2020-11-03  8:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-01 19:48 François Dumont
2020-11-02 14:17 ` Jonathan Wakely
2020-11-02 20:52   ` François Dumont
2020-11-03  8:25     ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201103082542.GV503596@redhat.com \
    --to=jwakely@redhat.com \
    --cc=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).