public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: [committed] libstdc++: Fix test failure with --disable-linux-futex
Date: Wed, 4 Nov 2020 15:35:03 +0000	[thread overview]
Message-ID: <20201104153503.GA3211486@redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 467 bytes --]

As noted in PR 96817 this new test fails if the library is built without
futexes. That's expected of course, but we might as well fail more
obviously than a deadlock that eventually times out.

libstdc++-v3/ChangeLog:

	* testsuite/18_support/96817.cc: Fail fail if the library is
	configured to not use futexes.

Tested powerpc64le-linux. Committed to trunk.

I've just realised the changelog above should say "Fail fast", I'll
fix that in the ChangeLog tomorrow.



[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 1016 bytes --]

commit 9c1125c121423a9948fa39e71ef89ba4059a2fad
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Wed Nov 4 15:24:47 2020

    libstdc++: Fix test failure with --disable-linux-futex
    
    As noted in PR 96817 this new test fails if the library is built without
    futexes. That's expected of course, but we might as well fail more
    obviously than a deadlock that eventually times out.
    
    libstdc++-v3/ChangeLog:
    
            * testsuite/18_support/96817.cc: Fail fail if the library is
            configured to not use futexes.

diff --git a/libstdc++-v3/testsuite/18_support/96817.cc b/libstdc++-v3/testsuite/18_support/96817.cc
index f03329678313..4591a7288a57 100644
--- a/libstdc++-v3/testsuite/18_support/96817.cc
+++ b/libstdc++-v3/testsuite/18_support/96817.cc
@@ -24,6 +24,10 @@
 #include <exception>
 #include <stdlib.h>
 
+#ifndef _GLIBCXX_HAVE_LINUX_FUTEX
+# error "This test requries futex support in the library"
+#endif
+
 int init()
 {
 #if __has_include(<sys/single_threaded.h>)

                 reply	other threads:[~2020-11-04 15:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201104153503.GA3211486@redhat.com \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).