public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] 1/2 Make _GLIBCXX_DEBUG checks constexpr compatible
Date: Mon, 9 Nov 2020 12:58:01 +0000	[thread overview]
Message-ID: <20201109125801.GN503596@redhat.com> (raw)
In-Reply-To: <60e247d6-f0b5-7613-34ea-2810e84d9ca1@gmail.com>

On 08/11/20 15:06 +0100, François Dumont via Libstdc++ wrote:
>Now that __glibcxx_assert is constexpr compatible we can do the same 
>for the _GLIBCXX_DEBUG equivalent.
>
>I had also try to do the same on my own so this patch contains the 
>string_view tests I had written when doing so.
>
>I plan to activate some _GLIBCXX_DEBUG checks when _GLIBCXX_ASSERTIONS 
>is defined but only the contant time checks. Is it ok to run checks 
>like __check_partitioned_lower in constexpr ?

Hmm, I don't *think* it's possible to detect the additional calls to
the comparison function during constant evaluation. So I think the
only concern is the extra work the compiler has to do, i.e. the extra
time it takes to compile.

The constant-time checks should be OK though.


>    libstdc++: Make _GLIBCXX_DEBUG checks constexpr compatible
[snip]
>Ok to commit ?

Yes, thanks.


      reply	other threads:[~2020-11-09 12:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-08 14:06 François Dumont
2020-11-09 12:58 ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201109125801.GN503596@redhat.com \
    --to=jwakely@redhat.com \
    --cc=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).