Re: [PATCH] 2/2 Remove debug/array

public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed

From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] 2/2 Remove debug/array
Date: Mon, 9 Nov 2020 13:07:09 +0000	[thread overview]
Message-ID: <20201109130709.GO503596@redhat.com> (raw)
In-Reply-To: <3d491a64-3d3d-0d00-a98e-a8b30ab27102@gmail.com>

On 08/11/20 15:27 +0100, FranÃ§ois Dumont via Libstdc++ wrote:
>Following a recent fix on std::array this test started to fail in 
>_GLIBCXX_DEBUG mode.
>
>FAIL: 23_containers/array/comparison_operators/96851.cc (test for 
>excess errors)
>
>Rather than fixing it and now that __glibcxx_assert is constexpr 
>compatible I would like to propose to simply remove 
>__gnu_debug::array.
>
>The only code we are losing with this change are the 
>_Array_check_nonempty/_Array_check_subscript types. I am not sure 
>about the purpose of this code as I saw no impact on tests. Maybe it 
>was to avoid assertion in constexpr where the value of the expression 
>is not use but there is a test doing that and it does produce an 
>assertion.
>
>Note that I am also moving std::array in versioned namespace. It is 
>just for consistency so no problem to remove it.
>
>I also manually edited include/Makefile.in cause I do not have the 
>proper autoreconf version. Can you regenerate it on your side once 
>patch is in ?
>
>Â Â Â  libstdc++: Remove <debug/array>
>
>Â Â Â  Add _GLIBCXX_ASSERTIONS assert in normal std::array and remove 
>__gnu_debug::array
>Â Â Â  implementation.
>
>Â Â Â  libstdc++-v3/ChangeLog:
>
>Â Â Â Â Â Â Â Â Â Â Â  * include/debug/array: Remove.
>Â Â Â Â Â Â Â Â Â Â Â  * include/Makefile.am: Remove <debug/array>.
>Â Â Â Â Â Â Â Â Â Â Â  * include/Makefile.in: Regenerate.
>Â Â Â Â Â Â Â Â Â Â Â  * include/experimental/functional: Adapt.
>Â Â Â Â Â Â Â Â Â Â Â  * include/std/array: Move to _GLIBCXX_INLINE_VERSION namespace.
>Â Â Â Â Â Â Â Â Â Â Â  * include/std/functional: Adapt.
>Â Â Â Â Â Â Â Â Â Â Â  * include/std/span: Adapt.
>Â Â Â Â Â Â Â Â Â Â Â  * testsuite/23_containers/array/debug/back1_neg.cc:
>Â Â Â Â Â Â Â Â Â Â Â  Remove dg-require-debug-mode. Add -D_GLIBCXX_ASSERTIONS option.
>Â Â Â Â Â Â Â Â Â Â Â  * testsuite/23_containers/array/debug/back2_neg.cc: Likewise.
>Â Â Â Â Â Â Â Â Â Â Â  * testsuite/23_containers/array/debug/front1_neg.cc: Likewise.
>Â Â Â Â Â Â Â Â Â Â Â  * testsuite/23_containers/array/debug/front2_neg.cc: Likewise.
>Â Â Â Â Â Â Â Â Â Â Â  * 
>testsuite/23_containers/array/debug/square_brackets_operator1_neg.cc:
>Â Â Â Â Â Â Â Â Â Â Â  Likewise.
>Â Â Â Â Â Â Â Â Â Â Â  * 
>testsuite/23_containers/array/debug/square_brackets_operator2_neg.cc:
>Â Â Â Â Â Â Â Â Â Â Â  Likewise.
>Â Â Â Â Â Â Â Â Â Â Â  * testsuite/23_containers/array/element_access/60497.cc
>Â Â Â Â Â Â Â Â Â Â Â  * 
>testsuite/23_containers/array/tuple_interface/get_debug_neg.cc:
>Â Â Â Â Â Â Â Â Â Â Â  Remove.
>Â Â Â Â Â Â Â Â Â Â Â  * testsuite/23_containers/array/tuple_interface/get_neg.cc
>Â Â Â Â Â Â Â Â Â Â Â  * testsuite/23_containers/array/tuple_interface/tuple_element_debug_neg.cc
>Â Â Â Â Â Â Â Â Â Â Â  * 
>testsuite/23_containers/array/tuple_interface/tuple_element_neg.cc
>
>Tested under Linux x86_64 normal and debug modes.
>
>Ok to commit ?

Yes, this is a nice simplification, thanks.

next prev parent reply	other threads:[~2020-11-09 13:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-08 14:27 François Dumont
2020-11-09 13:07 ` Jonathan Wakely [this message]
2020-12-03 17:09   ` Jonathan Wakely
2020-12-03 17:14     ` Daniel Krügler
2020-12-03 17:21       ` Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201109130709.GO503596@redhat.com \
    --to=jwakely@redhat.com \
    --cc=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).