From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id BDC2F3851C27 for ; Mon, 9 Nov 2020 13:07:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BDC2F3851C27 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-66-DO9CbDsVNpGn27CC8V0Ymw-1; Mon, 09 Nov 2020 08:07:11 -0500 X-MC-Unique: DO9CbDsVNpGn27CC8V0Ymw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6828A5F9CB; Mon, 9 Nov 2020 13:07:10 +0000 (UTC) Received: from localhost (unknown [10.33.36.44]) by smtp.corp.redhat.com (Postfix) with ESMTP id E6A845D9D2; Mon, 9 Nov 2020 13:07:09 +0000 (UTC) Date: Mon, 9 Nov 2020 13:07:09 +0000 From: Jonathan Wakely To: =?iso-8859-1?Q?Fran=E7ois?= Dumont Cc: "libstdc++@gcc.gnu.org" , gcc-patches Subject: Re: [PATCH] 2/2 Remove debug/array Message-ID: <20201109130709.GO503596@redhat.com> References: <3d491a64-3d3d-0d00-a98e-a8b30ab27102@gmail.com> MIME-Version: 1.0 In-Reply-To: <3d491a64-3d3d-0d00-a98e-a8b30ab27102@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2020 13:07:15 -0000 On 08/11/20 15:27 +0100, François Dumont via Libstdc++ wrote: >Following a recent fix on std::array this test started to fail in >_GLIBCXX_DEBUG mode. > >FAIL: 23_containers/array/comparison_operators/96851.cc (test for >excess errors) > >Rather than fixing it and now that __glibcxx_assert is constexpr >compatible I would like to propose to simply remove >__gnu_debug::array. > >The only code we are losing with this change are the >_Array_check_nonempty/_Array_check_subscript types. I am not sure >about the purpose of this code as I saw no impact on tests. Maybe it >was to avoid assertion in constexpr where the value of the expression >is not use but there is a test doing that and it does produce an >assertion. > >Note that I am also moving std::array in versioned namespace. It is >just for consistency so no problem to remove it. > >I also manually edited include/Makefile.in cause I do not have the >proper autoreconf version. Can you regenerate it on your side once >patch is in ? > >    libstdc++: Remove > >    Add _GLIBCXX_ASSERTIONS assert in normal std::array and remove >__gnu_debug::array >    implementation. > >    libstdc++-v3/ChangeLog: > >            * include/debug/array: Remove. >            * include/Makefile.am: Remove . >            * include/Makefile.in: Regenerate. >            * include/experimental/functional: Adapt. >            * include/std/array: Move to _GLIBCXX_INLINE_VERSION namespace. >            * include/std/functional: Adapt. >            * include/std/span: Adapt. >            * testsuite/23_containers/array/debug/back1_neg.cc: >            Remove dg-require-debug-mode. Add -D_GLIBCXX_ASSERTIONS option. >            * testsuite/23_containers/array/debug/back2_neg.cc: Likewise. >            * testsuite/23_containers/array/debug/front1_neg.cc: Likewise. >            * testsuite/23_containers/array/debug/front2_neg.cc: Likewise. >            * >testsuite/23_containers/array/debug/square_brackets_operator1_neg.cc: >            Likewise. >            * >testsuite/23_containers/array/debug/square_brackets_operator2_neg.cc: >            Likewise. >            * testsuite/23_containers/array/element_access/60497.cc >            * >testsuite/23_containers/array/tuple_interface/get_debug_neg.cc: >            Remove. >            * testsuite/23_containers/array/tuple_interface/get_neg.cc >            * testsuite/23_containers/array/tuple_interface/tuple_element_debug_neg.cc >            * >testsuite/23_containers/array/tuple_interface/tuple_element_neg.cc > >Tested under Linux x86_64 normal and debug modes. > >Ok to commit ? Yes, this is a nice simplification, thanks.