From: Jonathan Wakely <jwakely@redhat.com>
To: Jonathan Wakely via Libstdc++ <libstdc++@gcc.gnu.org>
Cc: Mike Crowe <mac@mcrowe.com>, gcc-patches@gcc.gnu.org
Subject: Re: [committed] libstdc++: Use custom timespec in system calls [PR 93421]
Date: Thu, 19 Nov 2020 13:33:43 +0000 [thread overview]
Message-ID: <20201119133343.GD1312820@redhat.com> (raw)
In-Reply-To: <20201118202253.GG503596@redhat.com>
On 18/11/20 20:22 +0000, Jonathan Wakely wrote:
>On 18/11/20 00:01 +0000, Jonathan Wakely wrote:
>>On 14/11/20 14:23 +0000, Jonathan Wakely wrote:
>>>On Sat, 14 Nov 2020, 13:30 Mike Crowe wrote:
>>>>>@@ -195,7 +205,7 @@ namespace
>>>>> if (__s.count() < 0) [[unlikely]]
>>>>> return false;
>>>>>
>>>>>- struct timespec rt;
>>>>>+ syscall_timespec rt;
>>>>> if (__s.count() > __int_traits<time_t>::__max) [[unlikely]]
>>>>> rt.tv_sec = __int_traits<time_t>::__max;
>>>>
>>>>Do these now need to be __int_traits<long>::__max in case time_t is 64-bit
>>>>yet syscall_timespec is using 32-bit long?
>>>>
>>>
>>>Ah yes. Maybe decltype(rt.tv_sec).
>>
>>I'll fix that in the next patch.
>
>And here's that next patch. I'm testing this and will commit if all
>goes well.
Committed.
prev parent reply other threads:[~2020-11-19 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 0:17 Jonathan Wakely
2020-11-14 13:29 ` Mike Crowe
2020-11-14 14:23 ` Jonathan Wakely
2020-11-18 0:01 ` Jonathan Wakely
2020-11-18 20:22 ` Jonathan Wakely
2020-11-18 20:49 ` Mike Crowe
2020-11-19 13:33 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119133343.GD1312820@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=mac@mcrowe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).