Re: [committed] libstdc++: Add "futex" and "gthreads" effective-target keywords

[Jonathan Wakely <jwakely@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 552 bytes --]

On 26/11/20 17:10 +0000, Jonathan Wakely wrote:
>On 26/11/20 16:25 +0000, Jonathan Wakely wrote:
>>+# Return 1 if futex syscall is available
>>+proc check_effective_target_gthreads { } {
>>+    return [check_v3_target_gthreads_timed]
>
>Oops, I've just noticed the comment is wrong and this calls the wrong
>proc. It should be check_v3_target_gthreads not
>check_v3_target_gthreads_timed.
>
>I'm in the process of refactoring it anyway so will fix it.

The refactoring is gling slowly, so here the fix.

Tested powerpc64le-linux. Committed to trunk.



[-- Attachment #2: patch.txt --]
[-- Type: text/x-patch, Size: 1451 bytes --]

commit 1a00786414c7ee2f228562fab5c43491a13284c1
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu Nov 26 21:41:15 2020

    libstc++: Fix typo in new check_effective_target_gthreads proc
    
    Also fix copy&pasted comments referring to the wrong things.
    
    libstdc++-v3/ChangeLog:
    
            * testsuite/lib/libstdc++.exp (check_effective_target_gthreads):
            Call check_v3_target_gthreads not check_v3_target_gthreads_timed.

diff --git a/libstdc++-v3/testsuite/lib/libstdc++.exp b/libstdc++-v3/testsuite/lib/libstdc++.exp
index bde8cc0cc91f..b94116ff4ea5 100644
--- a/libstdc++-v3/testsuite/lib/libstdc++.exp
+++ b/libstdc++-v3/testsuite/lib/libstdc++.exp
@@ -1619,7 +1619,8 @@ proc check_effective_target_tbb-backend { } {
 # Return 1 if futex syscall is available
 proc check_effective_target_futex { } {
     return [check_v3_target_prop_cached et_futex {
-	# Set up and compile a C++ test program that depends on tbb
+	# Set up and compile a C++ test program that depends on futex
+	# being supported.
 	set src futex[pid].cc
 	set exe futex[pid].x
 
@@ -1643,9 +1644,10 @@ proc check_effective_target_futex { } {
     }]
 }
 
-# Return 1 if futex syscall is available
+# Return 1 if C++11 [threads] facilities are available via gthreads,
+# 0 otherwise.
 proc check_effective_target_gthreads { } {
-    return [check_v3_target_gthreads_timed]
+    return [check_v3_target_gthreads]
 }
 
 set additional_prunes ""