From: Jonathan Wakely <jwakely@redhat.com>
To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Cc: Martin Liska <mliska@suse.cz>
Subject: [PATCH] gcc-changelog: Add libstdc++-v3/testsuite to wildcard prefixes
Date: Fri, 27 Nov 2020 16:23:54 +0000 [thread overview]
Message-ID: <20201127162354.GA2308844@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]
This allows using "testsuite/*" in libstdc++-v3/ChangeLog entries, which
was one of the original motivations for adding wildcard support in the
first place:
https://gcc.gnu.org/pipermail/gcc/2020-June/232719.html
contrib/ChangeLog:
* gcc-changelog/git_commit.py (wildcard_prefixes): Add libstdc++
testsuite directory.
OK to push?
This still doesn't actually meet my needs, because I'd like to be able
to do:
* testsuite/foo/*: Something for foo tests.
* testsuite/bar/baz/*: Something for baz tests.
So it would be nice if wildcards worked for any directory below a
wildcard prefix (as long as the directory actually exists).
It also seems that I can't have a commit where all changes are
described by a wildcard entry. It seems to require a non-wildcard one
too. But that means I can't make changes to hundreds of tests without
also making some other change, or doing something like:
* testsuite/foo/foo-1.cc: A specific change.
* testsuite/*: Likewise.
I suppose I can live with the latter, but it would still be nice if
this worked:
* testsuite/foo/foo-1.cc: A specific change.
* testsuite/foo/*: Likewise.
* testsuite/bar/baz/*: Likewise.
i.e. sub-directories below a wildcard prefix.
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 989 bytes --]
commit 5cdb6541a49f1ac716a3f1be281c9487d9b198c5
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Fri Nov 27 16:00:58 2020
gcc-changelog: Add libstdc++-v3/testsuite to wildcard prefixes
This allows using "testsuite/*" in libstdc++-v3/ChangeLog entries, which
was one of the original motivations for adding wildcard support in the
first place:
https://gcc.gnu.org/pipermail/gcc/2020-June/232719.html
contrib/ChangeLog:
* gcc-changelog/git_commit.py (wildcard_prefixes): Add libstdc++
testsuite directory.
diff --git a/contrib/gcc-changelog/git_commit.py b/contrib/gcc-changelog/git_commit.py
index d0ac23c22aa4..3ebc6fd305e0 100755
--- a/contrib/gcc-changelog/git_commit.py
+++ b/contrib/gcc-changelog/git_commit.py
@@ -138,7 +138,8 @@ ignored_prefixes = {
wildcard_prefixes = {
'gcc/testsuite/',
- 'libstdc++-v3/doc/html/'
+ 'libstdc++-v3/doc/html/',
+ 'libstdc++-v3/testsuite/'
}
misc_files = {
next reply other threads:[~2020-11-27 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 16:23 Jonathan Wakely [this message]
2020-11-30 9:43 ` Martin Liška
2020-11-30 11:58 ` Jonathan Wakely
2020-11-30 12:14 ` Martin Liška
2020-11-30 12:23 ` Jonathan Wakely
2020-11-30 12:43 ` Martin Liška
2020-11-30 12:48 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201127162354.GA2308844@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).