From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 6C58D3833010 for ; Wed, 2 Dec 2020 00:40:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6C58D3833010 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-552-e9NTqxneOgOW1fAvZUd6nA-1; Tue, 01 Dec 2020 19:40:40 -0500 X-MC-Unique: e9NTqxneOgOW1fAvZUd6nA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 16C1E107AFA9; Wed, 2 Dec 2020 00:40:38 +0000 (UTC) Received: from localhost (unknown [10.33.37.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id B21FF19C71; Wed, 2 Dec 2020 00:40:37 +0000 (UTC) Date: Wed, 2 Dec 2020 00:40:36 +0000 From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [committed] libstdc++: Fix filesystem::path pretty printer test failure Message-ID: <20201202004036.GA3140395@redhat.com> MIME-Version: 1.0 X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="3MwIy2ne0vdjdPXF" Content-Disposition: inline X-Spam-Status: No, score=-14.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2020 00:40:45 -0000 --3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On some systems libstdc++-prettyprinters/cxx17.cc FAILs with this error: skipping: Python Exception 'gdb.Type' object has no attribute 'name': ^M got: $27 = filesystem::path "/dir/."^M FAIL: libstdc++-prettyprinters/cxx17.cc print path2 The gdb.Type.name attribute isn't present in GDB 7.6, so we get an exception from StdPathPrinter._iterator.__next__ trying to use it. The StdPathPrinter._iterator is already passed the type's name in its constructor, so we can just store that and use it instead of gdb.Type.name. libstdc++-v3/ChangeLog: * python/libstdcxx/v6/printers.py (StdExpPathPrinter): Store the name of the type and pass it to the iterator. (StdPathPrinter): Likewise. * testsuite/libstdc++-prettyprinters/filesystem-ts.cc: New test. Tested powerpc64le-linux. Committed to trunk. --3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="patch.txt" commit a70384f94c83895f97179b45c1a8d66202132af8 Author: Jonathan Wakely Date: Wed Dec 2 00:39:21 2020 libstdc++: Fix filesystem::path pretty printer test failure On some systems libstdc++-prettyprinters/cxx17.cc FAILs with this error: skipping: Python Exception 'gdb.Type' object has no attribute 'name': ^M got: $27 = filesystem::path "/dir/."^M FAIL: libstdc++-prettyprinters/cxx17.cc print path2 The gdb.Type.name attribute isn't present in GDB 7.6, so we get an exception from StdPathPrinter._iterator.__next__ trying to use it. The StdPathPrinter._iterator is already passed the type's name in its constructor, so we can just store that and use it instead of gdb.Type.name. libstdc++-v3/ChangeLog: * python/libstdcxx/v6/printers.py (StdExpPathPrinter): Store the name of the type and pass it to the iterator. (StdPathPrinter): Likewise. * testsuite/libstdc++-prettyprinters/filesystem-ts.cc: New test. diff --git a/libstdc++-v3/python/libstdcxx/v6/printers.py b/libstdc++-v3/python/libstdcxx/v6/printers.py index 478e44eefdf..4176f739004 100644 --- a/libstdc++-v3/python/libstdcxx/v6/printers.py +++ b/libstdc++-v3/python/libstdcxx/v6/printers.py @@ -1294,6 +1294,7 @@ class StdExpPathPrinter: def __init__ (self, typename, val): self.val = val + self.typename = typename start = self.val['_M_cmpts']['_M_impl']['_M_start'] finish = self.val['_M_cmpts']['_M_impl']['_M_finish'] self.num_cmpts = int (finish - start) @@ -1312,10 +1313,11 @@ class StdExpPathPrinter: t = self._path_type() if t: path = '%s [%s]' % (path, t) - return "filesystem::path %s" % path + return "experimental::filesystem::path %s" % path class _iterator(Iterator): - def __init__(self, cmpts): + def __init__(self, cmpts, pathtype): + self.pathtype = pathtype self.item = cmpts['_M_impl']['_M_start'] self.finish = cmpts['_M_impl']['_M_finish'] self.count = 0 @@ -1331,13 +1333,13 @@ class StdExpPathPrinter: self.count = self.count + 1 self.item = self.item + 1 path = item['_M_pathname'] - t = StdExpPathPrinter(item.type.name, item)._path_type() + t = StdExpPathPrinter(self.pathtype, item)._path_type() if not t: t = count return ('[%s]' % t, path) def children(self): - return self._iterator(self.val['_M_cmpts']) + return self._iterator(self.val['_M_cmpts'], self.typename) class StdPathPrinter: "Print a std::filesystem::path" @@ -1370,6 +1372,7 @@ class StdPathPrinter: class _iterator(Iterator): def __init__(self, impl, pathtype): + self.pathtype = pathtype if impl: # We can't access _Impl::_M_size because _Impl is incomplete # so cast to int* to access the _M_size member at offset zero, @@ -1402,7 +1405,7 @@ class StdPathPrinter: self.count = self.count + 1 self.item = self.item + 1 path = item['_M_pathname'] - t = StdPathPrinter(item.type.name, item)._path_type() + t = StdPathPrinter(self.pathtype, item)._path_type() if not t: t = count return ('[%s]' % t, path) diff --git a/libstdc++-v3/testsuite/libstdc++-prettyprinters/filesystem-ts.cc b/libstdc++-v3/testsuite/libstdc++-prettyprinters/filesystem-ts.cc new file mode 100644 index 00000000000..692d79fa5a6 --- /dev/null +++ b/libstdc++-v3/testsuite/libstdc++-prettyprinters/filesystem-ts.cc @@ -0,0 +1,39 @@ +// { dg-options "-g -O0 -lstdc++fs" } +// { dg-do run { target c++11 } } +// { dg-require-filesystem-ts "" } + +// Copyright (C) 2020 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// . + +#include +#include + +int +main() +{ + std::experimental::filesystem::path path0; +// { dg-final { note-test path0 {experimental::filesystem::path ""} } } + std::experimental::filesystem::path path1("filename"); +// { dg-final { note-test path1 {experimental::filesystem::path "filename"} } } + std::experimental::filesystem::path path2("/dir/."); +// { dg-final { note-test path2 {experimental::filesystem::path "/dir/." = {[root-directory] = "/", [1] = "dir", [2] = "."}} } } + + std::cout << "\n"; + return 0; // Mark SPOT +} + +// { dg-final { gdb-test SPOT } } --3MwIy2ne0vdjdPXF--