From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id BF6523858C27 for ; Thu, 3 Dec 2020 19:32:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BF6523858C27 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-249-XxOe7nSSOrGr_dmIQGLU8A-1; Thu, 03 Dec 2020 14:32:02 -0500 X-MC-Unique: XxOe7nSSOrGr_dmIQGLU8A-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 889B2100C600; Thu, 3 Dec 2020 19:32:01 +0000 (UTC) Received: from localhost (unknown [10.33.37.15]) by smtp.corp.redhat.com (Postfix) with ESMTP id 277C61A890; Thu, 3 Dec 2020 19:32:00 +0000 (UTC) Date: Thu, 3 Dec 2020 19:32:00 +0000 From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [committed] libstdc++: Add std::bit_cast for C++20 [PR 93121] Message-ID: <20201203193200.GA2309743@redhat.com> References: <20201203192555.GA3795239@redhat.com> MIME-Version: 1.0 In-Reply-To: <20201203192555.GA3795239@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="T4IYkFBVPN84tP7K" Content-Disposition: inline X-Spam-Status: No, score=-14.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2020 19:32:25 -0000 --T4IYkFBVPN84tP7K Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On 03/12/20 19:25 +0000, Jonathan Wakely wrote: >Thanks to Jakub's addition of the built-in, we can add this to the >library now. The compiler tests for the built-in are quite extensive, >including verifying the constraints, so this only adds minimal tests to >the library testsuite. > >This doesn't add a new _GLIBCXX_HAVE_BUILTIN_BIT_CAST because using >__has_builtin(__builtin_bit_cast) works for GCC and versions of Clang >that provide the built-in. > >libstdc++-v3/ChangeLog: > > PR libstdc++/93121 > * include/std/bit (__cpp_lib_bit_cast, bit_cast): Define. > * include/std/version (__cpp_lib_bit_cast): Define. > * testsuite/26_numerics/bit/bit.cast/bit_cast.cc: New test. > * testsuite/26_numerics/bit/bit.cast/version.cc: New test. This fixes some typos in the new tests. Tested x86_64-linux. Committed to trunk. --T4IYkFBVPN84tP7K Content-Type: text/x-patch; charset=us-ascii Content-Disposition: attachment; filename="patch.txt" commit 656131e06aa76ba3cb50305c07cf5c8ee79fce44 Author: Jonathan Wakely Date: Thu Dec 3 19:30:02 2020 libstdc++: Fix typos in #error strings libstdc++-v3/ChangeLog: * testsuite/26_numerics/bit/bit.cast/bit_cast.cc: Remove stray word from copy&paste. * testsuite/26_numerics/bit/bit.cast/version.cc: Likewise. diff --git a/libstdc++-v3/testsuite/26_numerics/bit/bit.cast/bit_cast.cc b/libstdc++-v3/testsuite/26_numerics/bit/bit.cast/bit_cast.cc index b451f152b47..138ceb1c4d6 100644 --- a/libstdc++-v3/testsuite/26_numerics/bit/bit.cast/bit_cast.cc +++ b/libstdc++-v3/testsuite/26_numerics/bit/bit.cast/bit_cast.cc @@ -21,9 +21,9 @@ #include #ifndef __cpp_lib_bit_cast -# error "Feature-test macro for bit_cast wait missing in " +# error "Feature-test macro for bit_cast missing in " #elif __cpp_lib_bit_cast != 201806L -# error "Feature-test macro for bit_cast wait has wrong value in " +# error "Feature-test macro for bit_cast has wrong value in " #endif #include diff --git a/libstdc++-v3/testsuite/26_numerics/bit/bit.cast/version.cc b/libstdc++-v3/testsuite/26_numerics/bit/bit.cast/version.cc index 688d44bbb89..82e97543481 100644 --- a/libstdc++-v3/testsuite/26_numerics/bit/bit.cast/version.cc +++ b/libstdc++-v3/testsuite/26_numerics/bit/bit.cast/version.cc @@ -21,7 +21,7 @@ #include #ifndef __cpp_lib_bit_cast -# error "Feature-test macro for bit_cast wait missing in " +# error "Feature-test macro for bit_cast missing in " #elif __cpp_lib_bit_cast != 201806L -# error "Feature-test macro for bit_cast wait has wrong value in " +# error "Feature-test macro for bit_cast has wrong value in " #endif --T4IYkFBVPN84tP7K--