From: Jonathan Wakely <jwakely@redhat.com>
To: Ville Voutilainen <ville.voutilainen@gmail.com>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>,
libstdc++ <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Fix the test for rvalue stream extraction
Date: Tue, 15 Dec 2020 10:44:02 +0000 [thread overview]
Message-ID: <20201215104402.GI2309743@redhat.com> (raw)
In-Reply-To: <CAFk2RUbzxcdNhBwqkvWFPcByor6kY2F5smoqxTu0Xb=gxG3kKA@mail.gmail.com>
On 15/12/20 12:13 +0200, Ville Voutilainen via Libstdc++ wrote:
> libstdc++-v3/ChangeLog:
>
> * testsuite/27_io/rvalue_streams.cc: Run the extraction to a char*
> for C++17 and lower only.
OK, thanks.
>diff --git a/libstdc++-v3/testsuite/27_io/rvalue_streams.cc b/libstdc++-v3/testsuite/27_io/rvalue_streams.cc
>index ad4d11c7cf3..487aa4deedd 100644
>--- a/libstdc++-v3/testsuite/27_io/rvalue_streams.cc
>+++ b/libstdc++-v3/testsuite/27_io/rvalue_streams.cc
>@@ -53,7 +53,9 @@ test02()
> VERIFY( x.as_rvalue == true );
>
> char arr[2];
>+#if __cplusplus <= 201703L
> std::istringstream("x") >> &arr[0];
>+#endif
> std::istringstream("x") >> arr;
> }
>
prev parent reply other threads:[~2020-12-15 10:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 10:13 Ville Voutilainen
2020-12-15 10:44 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215104402.GI2309743@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ville.voutilainen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).