From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id CBC10394743D for ; Thu, 14 Jan 2021 13:08:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CBC10394743D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-533-Q6YGsk1GMMmuoiJ6b0JeeA-1; Thu, 14 Jan 2021 08:08:43 -0500 X-MC-Unique: Q6YGsk1GMMmuoiJ6b0JeeA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 36BA9107ACFE; Thu, 14 Jan 2021 13:08:42 +0000 (UTC) Received: from localhost (unknown [10.33.37.44]) by smtp.corp.redhat.com (Postfix) with ESMTP id 889C619C78; Thu, 14 Jan 2021 13:08:41 +0000 (UTC) Date: Thu, 14 Jan 2021 13:08:40 +0000 From: Jonathan Wakely To: Alexandre Oliva Cc: =?iso-8859-1?Q?Fran=E7ois?= Dumont , Jonathan Wakely , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org, Corentin Gay Subject: Re: Add dg-require-wchars to libstdc++ testsuite Message-ID: <20210114130840.GB7692@redhat.com> References: <6ebcdfda-bb74-793e-753d-983d45c48651@gmail.com> MIME-Version: 1.0 In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2021 13:08:49 -0000 On 13/01/21 14:29 -0300, Alexandre Oliva wrote: >On Dec 28, 2020, François Dumont wrote: > >> On 22/12/20 10:12 pm, Alexandre Oliva wrote: >>> Some tests uses structures from the libstdc++ that are present only if >>> the target has a wchar.h header. However, those tests do not check >>> that the target supports those constructs before executing the tests. > >> Looks like those tests should be in some sub-folder containing >> 'wchar_t' to be considered as UNSUP. > >> Maybe Jonathan will prefer them to be moved even if your approach >> seems more convenient to me. > >I'd be glad to make such changes, but I'd appreciate stronger guidance >as to the preferences and the way to go before doing so. Jonathan, >would you please share your wisdom WRT this patch and the other >wchar_t-related libstdc++ testsuite one? > >https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562435.html >https://gcc.gnu.org/pipermail/gcc-patches/2020-December/562438.html I'll look at them today. >>> The function dg-require-wchars checks that "_GLIBCXX_USE_WCHAR_T" is >>> defined by the configure of the libstdc++. If it is not the case, the >>> test is not executed. > >> This check_v3_target_wchars looks like a good candidate to leverage >> on: v3_check_preprocessor_condition. > >Nice!, thanks for the tip, I was not aware of this proc. It's only been there a few weeks.