From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 351D93988810 for ; Tue, 2 Feb 2021 15:02:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 351D93988810 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-WoqbOHaSMFGFdohH-ABYrA-1; Tue, 02 Feb 2021 10:02:25 -0500 X-MC-Unique: WoqbOHaSMFGFdohH-ABYrA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5109EAFA86; Tue, 2 Feb 2021 15:02:24 +0000 (UTC) Received: from localhost (unknown [10.33.37.24]) by smtp.corp.redhat.com (Postfix) with ESMTP id BEB335D9E8; Tue, 2 Feb 2021 15:02:23 +0000 (UTC) Date: Tue, 2 Feb 2021 15:02:23 +0000 From: Jonathan Wakely To: Matthias Kretz Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH 13/16] Improve test codegen for interpreting assembly Message-ID: <20210202150222.GE3008@redhat.com> References: <4667217.5jz8CO7rxU@excalibur> <18217938.xuKvIAzr1H@excalibur> MIME-Version: 1.0 In-Reply-To: <18217938.xuKvIAzr1H@excalibur> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-14.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2021 15:02:32 -0000 On 27/01/21 21:42 +0100, Matthias Kretz wrote: >From: Matthias Kretz > >In many failure cases it is helpful to inspect the instructions leading >up to the test failure. After this change the location is easier to find >and the branch after failure is easier to find. > >libstdc++-v3/ChangeLog: > * testsuite/experimental/simd/tests/bits/verify.h (verify): Add > instruction pointer data member. Ensure that the `if (m_failed)` > branch is always inlined into the calling code. The body of the > conditional can still be a function call. Move the get_ip call > into the verify ctor to simplify the ctor calls. > (COMPARE): Don't mention the use of all_of for reduction of a > simd_mask. It only distracts from the real issue. >--- > .../experimental/simd/tests/bits/verify.h | 44 +++++++++---------- > 1 file changed, 22 insertions(+), 22 deletions(-) > >diff --git a/libstdc++-v3/testsuite/experimental/simd/tests/bits/verify.h b/ >libstdc++-v3/testsuite/experimental/simd/tests/bits/verify.h Several of these patches have been mangled by your mailer. The line above has been wrapped in the middle of the filename, making this an invalid patch header. >@@ -220,24 +223,21 @@ template > > #define COMPARE(_a, _b) >\ And all these lines ending with a backslash have been wrapped. I can easily fix the filename in the header, but my simplistic attempts to put this back together have failed. Could you please resend patch 13/16 as an attachment, not inline? I think the others are OK.