From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Add unordered containers heterogeneous lookup
Date: Wed, 3 Feb 2021 11:24:10 +0000 [thread overview]
Message-ID: <20210203112410.GC116817@redhat.com> (raw)
In-Reply-To: <20210203112326.GB116817@redhat.com>
On 03/02/21 11:23 +0000, Jonathan Wakely wrote:
>On 25/01/21 19:21 +0100, François Dumont via Libstdc++ wrote:
>>I think I never got a clear answer that we'll wait for stage 1 to
>>consider this patch so here is a ping.
>
>My concern with this patch is that it alters the existing code used
>for non-heterogeneous lookups in C++11/14/17. I think if we're going
>to do thatk, it needs to wait for stage 1.
>
>If the new C++20 code was added with new _M_find_before_node and
s/_M_find_before_node/_M_find_before_node_tr/
>_M_find_node_tr members (duplicating the existing code) then it would
>be safe to add now, because it wouldn't touch the stable C++11/14/17
>code.
next prev parent reply other threads:[~2021-02-03 11:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 7:19 François Dumont
2021-01-25 18:21 ` François Dumont
2021-02-03 11:23 ` Jonathan Wakely
2021-02-03 11:24 ` Jonathan Wakely [this message]
2021-02-04 20:20 ` François Dumont
2021-02-09 11:18 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203112410.GC116817@redhat.com \
--to=jwakely@redhat.com \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).