From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id C1E85385043B for ; Mon, 8 Feb 2021 22:27:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C1E85385043B Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-501-Xo-jkFceOEeIIvjjK9Ypmw-1; Mon, 08 Feb 2021 17:27:12 -0500 X-MC-Unique: Xo-jkFceOEeIIvjjK9Ypmw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8308F1005501; Mon, 8 Feb 2021 22:27:11 +0000 (UTC) Received: from localhost (unknown [10.33.36.155]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1E79C60C5B; Mon, 8 Feb 2021 22:27:10 +0000 (UTC) Date: Mon, 8 Feb 2021 22:27:10 +0000 From: Jonathan Wakely To: Rainer Orth Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org, Matthias Kretz Subject: Re: [PATCH] libstdc++: Don't use reserved identifiers in simd headers Message-ID: <20210208222710.GT3008@redhat.com> References: MIME-Version: 1.0 In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Feb 2021 22:27:17 -0000 On 01/02/21 13:21 +0100, Rainer Orth wrote: >Two simd tests FAIL on Solaris, both SPARC and x86: > >FAIL: experimental/simd/standard_abi_usable.cc -msse2 -O2 -Wno-psabi (test for excess errors) >FAIL: experimental/simd/standard_abi_usable_2.cc -msse2 -O2 -Wno-psabi (test for excess errors) > >This happens because the simd headers use identifiers documented in the >libstdc++ manual as reserved by system headers. > >Fixed as follows, tested on i386-pc-solaris2.11, sparc-sun-solaris2.11, >and x86_64-pc-linux-gnu. > >Ok for master? OK, thanks. >As an aside, the use of vim: markers initially confused the hell out of >me. As an Emacs user, I rarely use vi for much more than a pager, but >when I wanted to check the lines mentioned in the g++ errors, I had no >idea what was going on or how to disable the folding enabled there: > >// vim: foldmethod=marker sw=2 noet ts=8 sts=2 tw=80 > >I can't help but feel that this is just a personal preference and >doesn't belong into the upstream code. > >For avoidance of doubt, I'd consider equivalent Emacs local variables >equally inappropriate. We do have Emacs mode lines in all the libstdc++ headers FWIW. I use a modified copy of https://www.vim.org/scripts/script.php?script_id=3381 to parse those modelines and set Vim config like sw=2 noet ts=2 etc. when it sees them. So I don't need vim: lines, because the Emacs ones work for me. I agree with removing the vim: lines if Matthias is happy to. The foldmethod is definitely awkward if that's not your preference.