From: Jonathan Wakely <jwakely@redhat.com>
To: Matthias Kretz <m.kretz@gsi.de>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 4/4] libstdc++: More efficient last day of month.
Date: Wed, 24 Feb 2021 18:54:06 +0000 [thread overview]
Message-ID: <20210224185406.GB3008@redhat.com> (raw)
In-Reply-To: <3154590.TO5rdG3zkT@excalibur>
On 23/02/21 23:13 +0100, Matthias Kretz wrote:
>I like the idea.
>
>On Dienstag, 23. Februar 2021 14:25:10 CET Cassio Neri via Libstdc++ wrote:
>> ((__m ^ (__m >> 3)) & 1) | 30
>
>Note that you can drop the `& 1` part. 30 in binary is 0b11110. ORing with a
>value in [0, 0b01101] will only toggle the last bit.
Yeah looks right to me.
I've committed all Cassio's patches unchanged (except for whitespace
and the dates on the tests) but we can make this additional
improvement too.
Thanks, Cassio. Nice first contributions to libstdc++!
prev parent reply other threads:[~2021-02-24 18:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 13:25 Cassio Neri
2021-02-23 22:13 ` Matthias Kretz
2021-02-24 18:54 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224185406.GB3008@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=m.kretz@gsi.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).