From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 22C0E388C016 for ; Thu, 4 Mar 2021 14:57:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 22C0E388C016 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-520-lm9JfDn_PSSktXjxYFlpUA-1; Thu, 04 Mar 2021 09:57:32 -0500 X-MC-Unique: lm9JfDn_PSSktXjxYFlpUA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3037A83DD22; Thu, 4 Mar 2021 14:57:30 +0000 (UTC) Received: from localhost (unknown [10.33.37.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id B7D8860C0F; Thu, 4 Mar 2021 14:57:29 +0000 (UTC) Date: Thu, 4 Mar 2021 14:57:28 +0000 From: Jonathan Wakely To: "Hoyer, David" Cc: libstdc++ Subject: Re: printers.py issue Message-ID: <20210304145728.GX3008@redhat.com> References: <20210304114719.GW3008@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Mar 2021 14:57:37 -0000 On 04/03/21 14:19 +0000, Hoyer, David via Libstdc++ wrote: >Thank you for this feedback. We are certainly writing our own pretty-print functions which leverage the printers.py function. These worked fine with the jessie GCC and stretch GDB. I will continue to investigate from my end to see if we are doing something wrong (heaven forbid that be possible 😉) I see. Then it might be possible that you're constructing a StdSetPrinter with a gdb.Type object as the "typename" argument. I when the libstdc++ printers are created they are always given a string for that argument. For problem 1 (the typ.unqualified() issue) I've done some digging (see https://sourceware.org/bugzilla/show_bug.cgi?id=27510 for details) and although I remain confused, I think typ.tag is what we want. We've already done strip_typedefs() so we should have a class type by that point, and .tag will be the unqualified class name. I'll test this patch: --- a/libstdc++-v3/python/libstdcxx/v6/printers.py +++ b/libstdc++-v3/python/libstdcxx/v6/printers.py @@ -85,8 +85,8 @@ except ImportError: def find_type(orig, name): typ = orig.strip_typedefs() while True: - # Strip cv-qualifiers. PR 67440. - search = '%s::%s' % (typ.unqualified(), name) + # Use Type.tag to ignore cv-qualifiers. PR 67440. + search = '%s::%s' % (typ.tag, name) try: return gdb.lookup_type(search) except RuntimeError: