From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id E0BB23858D29 for ; Mon, 15 Mar 2021 12:21:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E0BB23858D29 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-353-17a5hrGWMLivJUxlLVBpxw-1; Mon, 15 Mar 2021 08:20:57 -0400 X-MC-Unique: 17a5hrGWMLivJUxlLVBpxw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 54B4480006E; Mon, 15 Mar 2021 12:20:56 +0000 (UTC) Received: from localhost (unknown [10.33.36.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id E088A60C5F; Mon, 15 Mar 2021 12:20:55 +0000 (UTC) Date: Mon, 15 Mar 2021 12:20:54 +0000 From: Jonathan Wakely To: Iain Sandoe Cc: libstdc++ , GCC-patches@gcc.gnu.org Subject: Re: [PATCH] libstdc++, testsuite, Darwin : Adjust for names used in system headers. Message-ID: <20210315122054.GN3008@redhat.com> References: <11F9966D-6E1E-4B7E-B714-76EED90D6173@sandoe.co.uk> MIME-Version: 1.0 In-Reply-To: <11F9966D-6E1E-4B7E-B714-76EED90D6173@sandoe.co.uk> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2021 12:21:03 -0000 On 15/03/21 00:40 +0000, Iain Sandoe wrote: >Hi, > >What is slightly odd here is that this problem shows up for >installed testing, but not when the test-suite is run in-tree. > >However, the issue is clear (and doesn’t need to depend on >figuring out why it doesn’t show in-tree). > >tested on powerpc-darwin9, x86_64-darwin > >OK for master? >thanks >Iain > >==== > >For all current Darwin SDKs inttypes.h has: >extern intmax_t imaxabs(intmax_t j); > >So we need to exclude j from the defined symbol starts. > >libstdc++-v3/ChangeLog: > > * testsuite/17_intro/names.cc: Exclude j from the list > of symbol starts on Darwin platform. OK with adjusted changelog as discussed on IRC, thanks. > libstdc++-v3/testsuite/17_intro/names.cc | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/libstdc++-v3/testsuite/17_intro/names.cc b/libstdc++-v3/testsuite/17_intro/names.cc >index 4534d790772..624e3ed9ccf 100644 >--- a/libstdc++-v3/testsuite/17_intro/names.cc >+++ b/libstdc++-v3/testsuite/17_intro/names.cc >@@ -197,6 +197,11 @@ > #undef v > #endif > >+#ifdef __APPLE__ >+// inttypes.h: extern intmax_t imaxabs(intmax_t j); >+#undef j >+#endif >+ > #ifdef __hpux__ > #undef d > #undef r >-- >2.24.1 > >