From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 392E83858012 for ; Thu, 1 Apr 2021 14:07:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 392E83858012 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-436-xnmrdxGFNNq4Bqn3uKJcmw-1; Thu, 01 Apr 2021 10:07:24 -0400 X-MC-Unique: xnmrdxGFNNq4Bqn3uKJcmw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7E4791018F75; Thu, 1 Apr 2021 14:07:23 +0000 (UTC) Received: from localhost (unknown [10.33.36.164]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1C8135944C; Thu, 1 Apr 2021 14:07:22 +0000 (UTC) Date: Thu, 1 Apr 2021 15:07:22 +0100 From: Jonathan Wakely To: Patrick Palka Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH 2/3] libstdc++: Simplify copy-pasted algorithms in Message-ID: <20210401140722.GS3008@redhat.com> References: <20210329184915.3921422-1-ppalka@redhat.com> <20210329184915.3921422-2-ppalka@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210329184915.3921422-2-ppalka@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2021 14:07:28 -0000 On 29/03/21 14:49 -0400, Patrick Palka via Libstdc++ wrote: >The header currently copies some simple algorithms from >, which was originally done in order to avoid a >circular dependency with the header. This is no longer an issue since >the latter header now includes instead of all of >. > >This means we could now just include and remove the >copied algorithms, but that would double the size of . And we >can't use the corresponding STL-style algorithms here because they >assume input iterators are copyable. So this patch instead simplifies >these copied algorithms, removing their constraints and unused >parameters, and keeps them around. In a subsequent patch we're going to >copy ranges::find into as well. > >libstdc++-v3/ChangeLog: > > * include/std/ranges (__detail::find_if): Simplify. > (__detail::find_if_not): Likewise. > (__detail::min): Remove. > (__detail::mismatch): Simplify. > (take_view::size): Use std::min instead of __detail::min. I wonder if we want a which has this subset of algos. That could be used from and also from the real algos in . The ones in ranges_algobase.h wouldn't need to have the constraints (because we know the caller is constrained, or uses them correctly), but for that to work the unused params would need to be re-added. We can consider that for GCC 12 though. So OK for GCC 11.