From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id D5F763858012 for ; Thu, 1 Apr 2021 17:51:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D5F763858012 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-159-mC9pSPl7Mw6iU6OWbzuCYw-1; Thu, 01 Apr 2021 13:51:20 -0400 X-MC-Unique: mC9pSPl7Mw6iU6OWbzuCYw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C77D1802B5B; Thu, 1 Apr 2021 17:51:18 +0000 (UTC) Received: from localhost (unknown [10.33.36.164]) by smtp.corp.redhat.com (Postfix) with ESMTP id 52AF15C1BB; Thu, 1 Apr 2021 17:51:18 +0000 (UTC) Date: Thu, 1 Apr 2021 18:51:17 +0100 From: Jonathan Wakely To: Eric Botcazou Cc: Jakub Jelinek , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [committed] libstdc++: Test errno macros directly, not via autoconf [PR 93151] Message-ID: <20210401175117.GW3008@redhat.com> References: <20201216133809.GA1029023@redhat.com> <20210401142701.GA1179226@tucnak> <20210401151512.GU3008@redhat.com> <1864695.yKVeVyVuyW@fomalhaut> MIME-Version: 1.0 In-Reply-To: <1864695.yKVeVyVuyW@fomalhaut> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Apr 2021 17:51:23 -0000 On 01/04/21 18:47 +0200, Eric Botcazou wrote: >> Thanks, pushed. > >I can confirm that the build failure we had is now gone, thanks! > >> Eric, are you building the RC with --enable-maintainer-mode maybe? Or >> regenerating the autoconf files yourself? > >The latter, we have local configure changes so we regenerate the script. Aha, that explains it then. And it's useful that you noticed this before the final release!