From: Jonathan Wakely <jwakely@redhat.com>
To: libstdc++@gcc.gnu.org
Subject: [RFC] Deprecate non-standard constructors in std::pair
Date: Wed, 7 Apr 2021 13:30:50 +0100 [thread overview]
Message-ID: <20210407123050.GY3008@redhat.com> (raw)
This variation on the example in https://wg21.link/lwg811 is supposed
to be ill-formed:
pair<char*, unique_ptr<int>> p(0, std::make_unique<int>(0));
This cannot use the pair(U1&&, U2&&) constructor because it deduces
int for U1, which isn't convertible to char*. But it also cannot use
the pair(const first_type&, const second_type&) constructor, because
second_type is move-only.
It works in libstdc++ because extra non-standard constructors were
added by https://gcc.gnu.org/PR40925 when implementing LWG 811:
template<typename U1, /* constraints */>
explicit(/*...*/)
pair(U1&&, const second_type&);
template<typename U2, /* constraints */>
explicit(/*...*/)
pair(const first_type&, U2&&);
I think we should deprecate these extra constructors.
Unless I'm mistaken, those non-standard constructors have two uses:
- Support literal 0 as a constructor argument for a pointer type.
Such code should use nullptr instead. It exists to solve the problem
of 0 not deducing as a pointer type.
- Support {} as a constructor argument for a move-only type. I don't
think this was an intentional design choice (we don't test for it)
but it does work. Adopting https://wg21.link/p1951 for C++23 will
make that work anyway.
I propose that we deprecate the constructors for C++11/14/17/20 in
stage 1, and do not support them at all in C++23 mode once P1951 is
supported. I have a patch which I'll send in stage 1 (it also uses
C++20 concepts to simplify std::pair and fix PR 97930).
After a period of deprecation we could remove them, and support P1951
for -std=gnu++11/14/17/20 too so that {} continues to work.
next reply other threads:[~2021-04-07 12:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 12:30 Jonathan Wakely [this message]
2021-04-07 12:41 ` Ville Voutilainen
2021-04-07 12:46 ` Jonathan Wakely
2021-04-07 16:59 ` Jonathan Wakely
2021-04-07 17:18 ` Jonathan Wakely
2021-04-28 16:57 ` Jonathan Wakely
2021-04-28 17:19 ` Jonathan Wakely
2021-04-07 18:00 ` Jonathan Wakely
2021-04-07 18:17 ` Jonathan Wakely
2021-04-07 18:25 ` Ville Voutilainen
2021-04-07 18:26 ` Ville Voutilainen
2021-04-28 16:57 ` Jonathan Wakely
2021-04-28 17:00 ` Jonathan Wakely
2021-04-28 17:11 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407123050.GY3008@redhat.com \
--to=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).