* [PATCH] libstdc++: Add -latomic to test flags for 32-bit sparc-linux
@ 2021-04-15 16:00 Jonathan Wakely
2021-04-15 16:23 ` Eric Botcazou
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Wakely @ 2021-04-15 16:00 UTC (permalink / raw)
To: libstdc++, gcc-patches; +Cc: Eric Botcazou
[-- Attachment #1: Type: text/plain, Size: 396 bytes --]
Without this I see a number of tests failing when -m32 is used.
libstdc++-v3/ChangeLog:
* testsuite/lib/dg-options.exp (add_options_for_libatomic): Also
add libatomic options for 32-bit sparc*-*-linux-gnu.
Eric, are you OK with this? It adds -latomic and the appropriate -L
options to tests that use { dg-add-options libatomic }, because
sparcv8 needs libatomic for some std::atomic ops.
[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 1013 bytes --]
commit bbee87be3bfaa1ef19521870df998386f83d7ac2
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Thu Apr 15 16:39:55 2021
libstdc++: Add -latomic to test flags for 32-bit sparc-linux
Without this I see a number of tests failing when -m32 is used.
libstdc++-v3/ChangeLog:
* testsuite/lib/dg-options.exp (add_options_for_libatomic): Also
add libatomic options for 32-bit sparc*-*-linux-gnu.
diff --git a/libstdc++-v3/testsuite/lib/dg-options.exp b/libstdc++-v3/testsuite/lib/dg-options.exp
index 5160e4a72d1..7894973bcca 100644
--- a/libstdc++-v3/testsuite/lib/dg-options.exp
+++ b/libstdc++-v3/testsuite/lib/dg-options.exp
@@ -264,6 +264,7 @@ proc add_options_for_libatomic { flags } {
if { [istarget hppa*-*-hpux*]
|| ([istarget powerpc*-*-*] && [check_effective_target_ilp32])
|| [istarget riscv*-*-*]
+ || ([istarget sparc*-*-linux-gnu] && [check_effective_target_ilp32])
} {
return "$flags -L../../libatomic/.libs -latomic"
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libstdc++: Add -latomic to test flags for 32-bit sparc-linux
2021-04-15 16:00 [PATCH] libstdc++: Add -latomic to test flags for 32-bit sparc-linux Jonathan Wakely
@ 2021-04-15 16:23 ` Eric Botcazou
2021-04-15 16:43 ` Jonathan Wakely
0 siblings, 1 reply; 3+ messages in thread
From: Eric Botcazou @ 2021-04-15 16:23 UTC (permalink / raw)
To: Jonathan Wakely; +Cc: libstdc++, gcc-patches
> Without this I see a number of tests failing when -m32 is used.
>
> libstdc++-v3/ChangeLog:
>
> * testsuite/lib/dg-options.exp (add_options_for_libatomic): Also
> add libatomic options for 32-bit sparc*-*-linux-gnu.
>
> Eric, are you OK with this? It adds -latomic and the appropriate -L
> options to tests that use { dg-add-options libatomic }, because
> sparcv8 needs libatomic for some std::atomic ops.
Sure, thanks.
--
Eric Botcazou
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libstdc++: Add -latomic to test flags for 32-bit sparc-linux
2021-04-15 16:23 ` Eric Botcazou
@ 2021-04-15 16:43 ` Jonathan Wakely
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Wakely @ 2021-04-15 16:43 UTC (permalink / raw)
To: Eric Botcazou; +Cc: libstdc++, gcc-patches
On 15/04/21 18:23 +0200, Eric Botcazou wrote:
>> Without this I see a number of tests failing when -m32 is used.
>>
>> libstdc++-v3/ChangeLog:
>>
>> * testsuite/lib/dg-options.exp (add_options_for_libatomic): Also
>> add libatomic options for 32-bit sparc*-*-linux-gnu.
>>
>> Eric, are you OK with this? It adds -latomic and the appropriate -L
>> options to tests that use { dg-add-options libatomic }, because
>> sparcv8 needs libatomic for some std::atomic ops.
>
>Sure, thanks.
Thanks, pushed to trunk.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-15 16:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-15 16:00 [PATCH] libstdc++: Add -latomic to test flags for 32-bit sparc-linux Jonathan Wakely
2021-04-15 16:23 ` Eric Botcazou
2021-04-15 16:43 ` Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).