From: Jonathan Wakely <jwakely@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Update ppc64le baseline_symbols.txt
Date: Tue, 20 Apr 2021 11:35:51 +0100 [thread overview]
Message-ID: <20210420103551.GE3008@redhat.com> (raw)
In-Reply-To: <20210419130737.GG1179226@tucnak>
On 19/04/21 15:07 +0200, Jakub Jelinek wrote:
>On Fri, Apr 16, 2021 at 08:48:12PM +0200, Jakub Jelinek via Gcc-patches wrote:
>> Tested on powerpc64{,le}-linux now (-m32/-m64 on be) and while the first
>> patch works fine, the second one unfortunately doesn't on either be or le,
>> so more work is needed there. Thus, I'm withdrawing the second
>> * config/abi/post/powerpc64-linux-gnu/baseline_symbols.txt: Update.
>> only patch.
>
>Here are the needed changes to make it work.
>For symbols with _LDBL_ substring in version name we already have code to
>ignore those if no such symbols appear (but it is slightly incorrect, see
>below).
>So, this patch does the same thing for symbol versions with _IEEE128_
>substring.
>The previously incorrectly handled case is that in addition to
>FUNC:_ZNKSt17__gnu_cxx_ieee1287num_getIcSt19istreambuf_iteratorIcSt11char_traitsIcEEE14_M_extract_intImEES4_S4_S4_RSt8ios_baseRSt12_Ios_IostateRT_@@GLIBCXX_IEEE128_3.4.29
>or
>OBJECT:12:_ZTSu9__ieee128@@CXXABI_IEEE128_1.3.13
>cases we also have the
>OBJECT:0:CXXABI_IEEE128_1.3.13
>OBJECT:0:GLIBCXX_IEEE128_3.4.29
>cases, which have empty version_name and the name is in that case the
>symbol version. Those need to be ignored too.
>
>Tested on {powerpc64le,powerpc64,x86_64}-linux, ok for trunk?
OK for trunk and gcc-11, thanks.
prev parent reply other threads:[~2021-04-20 10:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210416151458.GN1179226@tucnak>
2021-04-16 18:48 ` [PATCH] libstdc++: Update ppc32 baseline_symbols.txt Jakub Jelinek
2021-04-16 19:33 ` Jonathan Wakely
2021-04-19 13:07 ` [PATCH] libstdc++: Update ppc64le baseline_symbols.txt Jakub Jelinek
2021-04-20 10:35 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420103551.GE3008@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).