From: Jonathan Wakely <jwakely@redhat.com>
To: Tim Song <t.canens.cpp@gmail.com>
Cc: Patrick Palka <ppalka@redhat.com>,
libstdc++ <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++: Implement P2328 changes to join_view
Date: Fri, 30 Apr 2021 23:02:13 +0100 [thread overview]
Message-ID: <20210430220213.GF3008@redhat.com> (raw)
In-Reply-To: <CAPQZVxtqLGHOGG+X37VJH2LD03CEZYtWe9ZnrLVBkQe4P0Rtfw@mail.gmail.com>
On 30/04/21 12:43 -0500, Tim Song via Libstdc++ wrote:
>On Fri, Apr 30, 2021 at 12:11 PM Patrick Palka via Libstdc++
><libstdc++@gcc.gnu.org> wrote:
>>
>> + template<typename _Iter>
>> + _Tp&
>> + _M_emplace_deref(const _Iter& __i)
>> + {
>> + this->reset();
>> + return this->emplace(*__i);
>> + }
>
>This incurs a move, avoiding of which is the sole reason for
>emplace-deref's existence.
I completely forgot about that, even though we only discussed it last
week. Thanks, Tim.
prev parent reply other threads:[~2021-04-30 22:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 14:38 Patrick Palka
2021-04-30 16:59 ` Jonathan Wakely
2021-04-30 17:43 ` Tim Song
2021-04-30 21:34 ` Patrick Palka
2021-04-30 22:01 ` Jonathan Wakely
2021-04-30 22:51 ` Patrick Palka
2021-04-30 22:02 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210430220213.GF3008@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ppalka@redhat.com \
--cc=t.canens.cpp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).