public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][_GLIBCXX_DEBUG] libbacktrace integration
Date: Fri, 7 May 2021 15:26:55 +0100	[thread overview]
Message-ID: <20210507142655.GE3008@redhat.com> (raw)
In-Reply-To: <20210505113337.GU3008@redhat.com>

On 05/05/21 12:33 +0100, Jonathan Wakely wrote:
>On 24/04/21 15:46 +0200, François Dumont via Libstdc++ wrote:
>>Hi
>>
>>    Here is the patch to add backtrace generation on _GLIBCXX_DEBUG 
>>assertions thanks to libbacktrace.

Ville pointed out that we'll need to use libbacktrace for
std::stacktrace <https://wg21.link/P0881R7> anyway, and it would be
useful if/when we add support for C++ Contracts to the lirbary.

So let's integrate libbacktrace into libstdc++ properly. Jakub
suggested doing it how libsanitizer does it, which is to rebuild the
libbacktrace sources as part of the libsanitizer build, using the
preprocessor to rename the symbols so that they use reserved names.
e.g. rename backtrace_full to __glibcxx_backtrace_full or something
like that.

I'll work on getting it building as part of libstdc++ (or maybe as a
separate static library for now, as we do for libstdc++fs.a) and then
you can rework your Debug Mode patch to depend on the private version
of libbacktrace included with libstdc++ (instead of expecting users to
provide it themselves).


  reply	other threads:[~2021-05-07 14:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-24 13:46 François Dumont
2021-05-03 20:17 ` François Dumont
2021-05-03 21:06   ` Jonathan Wakely
2021-05-04  6:03     ` François Dumont
2021-05-05 10:01       ` Jonathan Wakely
2021-05-05 11:33 ` Jonathan Wakely
2021-05-07 14:26   ` Jonathan Wakely [this message]
2021-05-09 15:03     ` François Dumont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210507142655.GE3008@redhat.com \
    --to=jwakely@redhat.com \
    --cc=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).