From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8DB253858410 for ; Fri, 5 Nov 2021 18:17:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8DB253858410 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-130-CBK1yZlXM-6U9fHFN7c6jQ-1; Fri, 05 Nov 2021 14:17:42 -0400 X-MC-Unique: CBK1yZlXM-6U9fHFN7c6jQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 37A0310A8E11; Fri, 5 Nov 2021 18:17:41 +0000 (UTC) Received: from localhost (unknown [10.33.36.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id C8E0B60BF1; Fri, 5 Nov 2021 18:17:40 +0000 (UTC) From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [committed] libstdc++: Add [[unlikely]] attributes to std::random_device routines Date: Fri, 5 Nov 2021 18:17:39 +0000 Message-Id: <20211105181739.2245825-1-jwakely@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2021 18:17:47 -0000 Tested x86+64-linux, pushed to trunk. libstdc++-v3/ChangeLog: * src/c++11/random.cc (__x86_rdrand, __x86_rdseed): Add [[unlikely]] attribute. --- libstdc++-v3/src/c++11/random.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libstdc++-v3/src/c++11/random.cc b/libstdc++-v3/src/c++11/random.cc index 55a73c51fca..4b88818646f 100644 --- a/libstdc++-v3/src/c++11/random.cc +++ b/libstdc++-v3/src/c++11/random.cc @@ -97,7 +97,7 @@ namespace std _GLIBCXX_VISIBILITY(default) unsigned int retries = 100; unsigned int val; - while (__builtin_ia32_rdrand32_step(&val) == 0) + while (__builtin_ia32_rdrand32_step(&val) == 0) [[__unlikely__]] if (--retries == 0) std::__throw_runtime_error(__N("random_device: rdrand failed")); @@ -113,7 +113,7 @@ namespace std _GLIBCXX_VISIBILITY(default) unsigned int retries = 100; unsigned int val; - while (__builtin_ia32_rdseed_si_step(&val) == 0) + while (__builtin_ia32_rdseed_si_step(&val) == 0) [[__unlikely__]] { if (--retries == 0) { -- 2.31.1