From: Hans-Peter Nilsson <hp@axis.com>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: <gcc-patches@gcc.gnu.org>, <libstdc++@gcc.gnu.org>
Subject: Re: [PATCH] libstdc++-v3: Set 26_numerics/random/n.b.d./op./values.cc timeout-factor to 3
Date: Fri, 20 May 2022 16:30:25 +0200 [thread overview]
Message-ID: <20220520143025.235C92041C@pchp3.se.axis.com> (raw)
In-Reply-To: <CACb0b4km0+jbYMBQ=_oyfAHFwfpXv0-srSytz-=V9E8SSDp-Tg@mail.gmail.com> (message from Jonathan Wakely on Fri, 20 May 2022 11:03:40 +0200)
> From: Jonathan Wakely <jwakely@redhat.com>
> Date: Fri, 20 May 2022 11:03:40 +0200
> > Ok to commit (without renaming)?
>
> I'm OK with the timeout factor, but we could also solve it differently
> so that it doesn't take nearly 5 minutes, as in the attached patch.
> The testDiscreteDist function can be parametrized with the number of
> iterations to perform. Would you rather do that?
Yes thanks, down from 4m39s to 2.7 seconds, so very much
preferable!
(To the skeptics: the coverage intended with the test, is
IMHO reached with all non-simulator targets also running
this. Nothing target-dependent here.)
Also in line with many other depth-level-cousin test-files
named value.cc. Still many more others seem to be
candidates for such pruning, judging by the time it takes
for a 'RUNTESTFLAGS=--target_board=cris-sim\
conformance.exp=values.cc' to get to *that* values.cc.
Though, some -DSIMULATOR_TEST-adjusted files use dg-options,
others dg-additional-options. It seems the difference is
that by using dg-options, you lose "-include bits/stdc++.h".
Likely not intended. If so, should Someone fix that by
preapproval but regtested?
brgds, H-P
next prev parent reply other threads:[~2022-05-20 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 2:19 Hans-Peter Nilsson
2022-05-20 9:03 ` Jonathan Wakely
2022-05-20 9:22 ` Jonathan Wakely
2022-05-20 14:30 ` Hans-Peter Nilsson [this message]
2022-05-20 15:06 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220520143025.235C92041C@pchp3.se.axis.com \
--to=hp@axis.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).