From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9A0293858284 for ; Wed, 24 Aug 2022 19:40:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9A0293858284 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661370021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=X0YVNdK41c4VPfy9SgcmbXouJF0D02El6OVizrISSY0=; b=aNcPq8q5ae/wHEnKyyyNyveDPe5jytuVJogNDyHNQ0eAXXlTUinuhnvAoO9aV/QzDvPbY7 Im2R72kvV/S0QAoB50TVaW+E3hSdRycbHWgolQbftJNneOOEG2KL2LT7sYlNb7gJZw5gt7 cLkv24IZ8aCHuUSwc04AL/HF2ZTkIf0= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-610-kR33SwJmN0-4UZR6hrUGQQ-1; Wed, 24 Aug 2022 15:40:19 -0400 X-MC-Unique: kR33SwJmN0-4UZR6hrUGQQ-1 Received: by mail-qk1-f198.google.com with SMTP id bm11-20020a05620a198b00b006bb2388ef0cso15424695qkb.5 for ; Wed, 24 Aug 2022 12:40:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=X0YVNdK41c4VPfy9SgcmbXouJF0D02El6OVizrISSY0=; b=03mQZIMBtvToHATRo5xwiytm0xpCpx+cB6taTqZ6mSA8yDugAAfxhPpMSU7psmdzZ+ Ol4vur3ZBT3n4wAICAia7ddED8xvzkjy71kTJAMzAzHO+cCfEAiiAePsuAO8aX9VcoNS UXXedwNOpS0V0+kPMmP4qby1huxHVBX9fQ199kl44SmLjhdnat6jP2zq2lCbCHXIuV64 fgrFuoqGyNbzj/5W/lsnXlOBtDnkvCkBcUxpnWp5X7pP1VUEpwngMuTpb3YQ0ecu3iC8 infDB3Fy7BtQ2tV6aIIXW3/y4AhtLBU6QA9ZLr/1hQzXAYUdiEmwdq/63RksAGioQOKO pSaw== X-Gm-Message-State: ACgBeo0Yp6FdEnJzgRphsPPhKtTcY1KNdegrd5Oav/qTMPebflnohSNu 6jF2r6Pz3qTcI9Y6dO/Ae+LqC5hIWzWo83L44JqgenY7OVKR2iQDtgEc+hOMVFAFZ1d+q9/3JbA +nK70EgOljcZ0K54= X-Received: by 2002:a05:620a:46a2:b0:6bb:29c9:57e0 with SMTP id bq34-20020a05620a46a200b006bb29c957e0mr628441qkb.621.1661370018857; Wed, 24 Aug 2022 12:40:18 -0700 (PDT) X-Google-Smtp-Source: AA6agR68yowVl/MZm2xbLQ3d7tEiHzE8duqo3ufXZqlBN8DJR3qiLxilCKmiPoScEbpjHbKNaL+fzA== X-Received: by 2002:a05:620a:46a2:b0:6bb:29c9:57e0 with SMTP id bq34-20020a05620a46a200b006bb29c957e0mr628430qkb.621.1661370018554; Wed, 24 Aug 2022 12:40:18 -0700 (PDT) Received: from localhost.localdomain (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id hg17-20020a05622a611100b0034359fc348fsm12846369qtb.73.2022.08.24.12.40.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Aug 2022 12:40:18 -0700 (PDT) From: Patrick Palka To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Patrick Palka Subject: [PATCH] libstdc++: Optimize std::con/disjunction, __and_/__or_, etc Date: Wed, 24 Aug 2022 15:40:13 -0400 Message-Id: <20220824194013.2035464-1-ppalka@redhat.com> X-Mailer: git-send-email 2.37.2.382.g795ea8776b MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The internal type-level logical operations __and_ and __or_ are currently quite slow to compile for a couple of reasons: 1. They are drop-in replacements for std::con/disjunction, which are rigidly specified to form a type that derives from the first type argument that caused the overall computation to short-circuit. In practice this inheritance property seems to be rarely needed; usually all we care about is the value of the overall expression. 2. Their recursive implementations instantiate up to ~N class templates and form up to a depth ~N inheritance chain. This patch does away with this inheritance property of __and_ and __or_ (which seems to be unneeded in the library except indirectly by std::con/disjunction) and redefines them as alias templates that yield either false_type or true_type via SFINAE and overload resolution of a pair of function templates. As for std::con/disjunction, it seems we need to keep defining them in terms of recursive class templates for sake of the inheritance property. But in the recursive step, instead of using inheritance which would yield a depth ~N inheritance chain, use a recursive member typedef which gets immediately flattened. Thus a specialization of conjunction and disjunction now has depth ~1 instead of up to ~N. In passing, redefine __not_ as an alias template for consistency with __and_ and __or_, and to remove a layer of indirection. Together these changes have a substantial effect on compile time and memory usage for code that indirectly makes heavy use of these internal type traits. For example, for the following which tests constructibility between two compatible 257-element tuple types #include struct A { A(int); }; #define M(x) x, x using ty1 = std::tuple; using ty2 = std::tuple; static_assert(std::is_constructible_v); memory usage improves by ~27% from 440MB to 320M and compile time improves by ~20% from ~2s to ~1.6s (with -std=c++23). Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? libstdc++-v3/ChangeLog: * include/std/type_traits (enable_if, __enable_if_t): Move up their definitions. (__detail::__first_t): Define. (__detail::__or_fn, __detail::__and_fn): Declare. (__or_, __and_): Redefine as alias templates in terms of __or_fn and __and_fn. (__not_): Redefine as an alias template. (__detail::__disjunction_impl, __detail::__conjunction_impl): Define. (conjuction, disjunction): Redefine in terms of __disjunction_impl and __conjunction_impl. --- libstdc++-v3/include/std/type_traits | 152 ++++++++++++++++----------- 1 file changed, 93 insertions(+), 59 deletions(-) diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index 14b029cec64..07a50a31e86 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -100,6 +100,21 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION // Metaprogramming helper types. + // Primary template. + /// Define a member typedef `type` only if a boolean constant is true. + template + struct enable_if + { }; + + // Partial specialization for true. + template + struct enable_if + { typedef _Tp type; }; + + // __enable_if_t (std::enable_if_t for C++11) + template + using __enable_if_t = typename enable_if<_Cond, _Tp>::type; + template struct __conditional { @@ -127,56 +142,39 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION template using __type_identity_t = typename __type_identity<_Tp>::type; - template - struct __or_; - - template<> - struct __or_<> - : public false_type - { }; + namespace __detail + { + // A variadic alias template that resolves to its first argument. + template + using __first_t = _Tp; - template - struct __or_<_B1> - : public _B1 - { }; + // These are deliberately not defined. + template + auto __or_fn(int) -> __first_t...>; - template - struct __or_<_B1, _B2> - : public __conditional_t<_B1::value, _B1, _B2> - { }; + template + auto __or_fn(...) -> true_type; - template - struct __or_<_B1, _B2, _B3, _Bn...> - : public __conditional_t<_B1::value, _B1, __or_<_B2, _B3, _Bn...>> - { }; + template + auto __and_fn(int) -> __first_t...>; - template - struct __and_; + template + auto __and_fn(...) -> false_type; + } // namespace detail - template<> - struct __and_<> - : public true_type - { }; - - template - struct __and_<_B1> - : public _B1 - { }; - - template - struct __and_<_B1, _B2> - : public __conditional_t<_B1::value, _B2, _B1> - { }; + // Like C++17 std::dis/conjunction, but usable in C++11 and resolves + // to either true_type or false_type which allows for a more efficient + // implementation that avoids instantiating any class templates. + template + using __or_ = decltype(__detail::__or_fn<_Bn...>(0)); - template - struct __and_<_B1, _B2, _B3, _Bn...> - : public __conditional_t<_B1::value, __and_<_B2, _B3, _Bn...>, _B1> - { }; + template + using __and_ = decltype(__detail::__and_fn<_Bn...>(0)); template - struct __not_ - : public __bool_constant - { }; + using __not_ = __bool_constant; /// @endcond #if __cplusplus >= 201703L @@ -186,18 +184,69 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION inline constexpr bool __or_v = __or_<_Bn...>::value; template inline constexpr bool __and_v = __and_<_Bn...>::value; + + namespace __detail + { + template + struct __disjunction_impl; + + template<> + struct __disjunction_impl<> + { using type = false_type; }; + + template + struct __disjunction_impl<_B1> + { using type = _B1; }; + + template + struct __disjunction_impl<_B1, _B2> + { using type = __conditional_t<_B1::value, _B1, _B2>; }; + + template + struct __disjunction_impl<_B1, _B2, _B3, _Bn...> + { + using type + = __conditional_t<_B1::value, + _B1, + typename __disjunction_impl<_B2, _B3, _Bn...>::type>; + }; + + template + struct __conjunction_impl; + + template<> + struct __conjunction_impl<> + { using type = true_type; }; + + template + struct __conjunction_impl<_B1> + { using type = _B1; }; + + template + struct __conjunction_impl<_B1, _B2> + { using type = __conditional_t<_B1::value, _B2, _B1>; }; + + template + struct __conjunction_impl<_B1, _B2, _B3, _Bn...> + { + using type + = __conditional_t<_B1::value, + typename __conjunction_impl<_B2, _B3, _Bn...>::type, + _B1>; + }; + } // namespace __detail /// @endcond #define __cpp_lib_logical_traits 201510L template struct conjunction - : __and_<_Bn...> + : __detail::__conjunction_impl<_Bn...>::type { }; template struct disjunction - : __or_<_Bn...> + : __detail::__disjunction_impl<_Bn...>::type { }; template @@ -2219,23 +2268,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION using __decay_and_strip = __strip_reference_wrapper<__decay_t<_Tp>>; /// @endcond - // Primary template. - /// Define a member typedef `type` only if a boolean constant is true. - template - struct enable_if - { }; - - // Partial specialization for true. - template - struct enable_if - { typedef _Tp type; }; - /// @cond undocumented - // __enable_if_t (std::enable_if_t for C++11) - template - using __enable_if_t = typename enable_if<_Cond, _Tp>::type; - // Helper for SFINAE constraints template using _Require = __enable_if_t<__and_<_Cond...>::value>; -- 2.37.2.382.g795ea8776b