From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fencepost.gnu.org (fencepost.gnu.org [IPv6:2001:470:142:3::e]) by sourceware.org (Postfix) with ESMTPS id 984AF3858CDB; Fri, 7 Oct 2022 20:43:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 984AF3858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=erkg8E2zwSzXvGeVElxi7+8p0wSMs80ek4iAjTNxBp0=; b=St8FosO7LFB67aBtx/NB mnVZQa0P5ELDDBdPEEbDJYaupMIdKlu0vbl3o3lgDrpxYImOIcoNWlJEZe/xZj4feFU/RGfECu7Af LzdXe/FCbTHxc9cOUwGdybzDqnw+VdtqKAtU99wpI7GrCpzyIhrWG2SoT/3RSXomspuQsGP+19HCD ig0T+86QWp3sL+D67WODxfDfwY5adEwq0DyD6EAdORA80yHrlKn4dWO/5B9qKv7bZg+CTngZWBZi+ i5k4wseLPs9LMKG4lJSLoeucpJi+3B1e7jkEyRe6FmvAaQKtZr4EpVoxfnTHUnOxw39JaxcG4R15B Pl7X0NwTqX68Xw==; Received: from 2a01cb008c016e00de41a9fffe47ec49.ipv6.abo.wanadoo.fr ([2a01:cb00:8c01:6e00:de41:a9ff:fe47:ec49]:49718 helo=begin.home) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oguCC-0000av-Kn; Fri, 07 Oct 2022 16:43:49 -0400 Received: from samy by begin.home with local (Exim 4.96) (envelope-from ) id 1oguCA-001lmf-0Z; Fri, 07 Oct 2022 22:43:46 +0200 Date: Fri, 7 Oct 2022 22:43:46 +0200 From: Samuel Thibault To: Jonathan Wakely Cc: gcc-patches@gcc.gnu.org, bug-hurd@gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH] libstdc++: Introduce GNU/Hurd-specific libstdc++ os-defines.h Message-ID: <20221007204346.vc4w5zroxqd5zwkg@begin> Mail-Followup-To: Jonathan Wakely , gcc-patches@gcc.gnu.org, bug-hurd@gnu.org, libstdc++@gcc.gnu.org References: <20220829003040.kfgr7epzzyavbsjm@begin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, Jonathan Wakely, le ven. 07 oct. 2022 12:14:26 +0100, a ecrit: > As documented at https://gcc.gnu.org/lists.html all patches for > libstdc++ need to be CC'd to the libstdc++ list. That's why your patch > has not been reviewed, because I didn't see it. Ah, sorry, I hadn't noticed that. > On 29/08/22 02:30 +0200, Samuel Thibault wrote: > > This is notably needed because in glibc 2.34, the move of pthread functions > > into libc.so happened for Linux only, not GNU/Hurd. > > > > The pthread_self() function can also always be used fine as it is. > > > > libstdc++-v3/ChangeLog: > > > > > * config/os/gnu/os_defines.h: New file. > > * config/os/gnu/ctype_base.h: New file. > > * config/os/gnu/ctype_configure_char.cc: New file. > > * config/os/gnu/ctype_inline.h: New file. > > * configure.host: On gnu* host, use os/gnu instead of os/gnu-linux. > > I think the commit message should note that these files are all copied > from the existing gnu-linux ones, so that the git log records that and > people don't need to compare them manually. > > But if these files are all identical to the existing gnu-linux ones, > except for a couple of macros in os_defines.h being conditional on > Linux, why not just test __linux__ in os_defines.h? Ah, it's just that I hadn't seen that done for other OSes, even when they are very similar (e.g. between gnu-linux and uclibc). If #ifdef is fine there, then yes I'm all for it indeed. I'll send a v2. Samuel