From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by sourceware.org (Postfix) with ESMTPS id 1577D38582BE; Sun, 13 Nov 2022 20:29:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1577D38582BE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x532.google.com with SMTP id e13so5609607edj.7; Sun, 13 Nov 2022 12:29:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Pdx9yHm9ao7PQdQPMMEEd3jDE06qdDAFaJSXxAlRyeI=; b=VYfklg+yjHn4ytpp26M7sN7LuXljQXY/bE/69+CGzPwh+gevPb2z3EuolAct75mvey Irygr5wiV7I2YUNi0R6zDnHAAHxxZfk0+ZicJI8nQIhWuOpMiDUW0oVwx5uGUTYh5rab ek+uxhqsmi5jrBL7FH8r0a+X1Kq06mOUlDk/is9saHo910AOPeuTnhdZZU753pkwLxmu RqTI+1/ONwRoYg4m/vQM9Saf5g2HWgsLmgzEXJlaw12NynU0qt4sbU0f+LiqFCs0ILd3 W706NTdy9W0AxPEV1bjybM6Ipc9yYu6wCfJj/WKlnzkA9FELbJQAC9anTlZKEkoTzGts BG8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pdx9yHm9ao7PQdQPMMEEd3jDE06qdDAFaJSXxAlRyeI=; b=LU+HJDgvcKpZdJh8d3vTV3f7ePmwL7QtNJOJHSgpXo4w+Z6rnZr5ja3chLA6rAi6od 9pSPutZidM9ZT/qrmKrIPKjExUzgE9LG5FEOVvLJq/P8No5hNRmyj13BWJrKABZBWdU6 Yxm0BtAL6hUeS91SSvsgWlCY4GNiX2AIxC0+2zfPvm2vXP16vvraSWVUgVHWjEEy3bnS 4NSoYQiyUWQdD+7KOdd8fF77QtAqqsQZmpfCBl43fLkucQtXm6I1nkoOTWhoL9e11Wlt KRMjewO6CpI48Ns5IkATy/IcvM1tyPg8ZL7DXMKgCnjPHB4TvBSbKHNKM/v7bNBosE+u k5Zg== X-Gm-Message-State: ANoB5pljRQPVbaWbQSw3O+AOpI28hVmMnmVZHyU6e4VV1KMN0j1qzshi 59rzaW2IBgMRL7u2EtVW3vk= X-Google-Smtp-Source: AA0mqf4BNoyRdQGJyTVqkCSiIm9jS5UkfLdmUf7oC06EXFPj09Q++yHrewBH2y0I202f8gp708sqSw== X-Received: by 2002:a05:6402:1141:b0:467:3ea2:3ec4 with SMTP id g1-20020a056402114100b004673ea23ec4mr9066523edw.351.1668371396560; Sun, 13 Nov 2022 12:29:56 -0800 (PST) Received: from nbbrfq (80-110-214-113.static.upcbusiness.at. [80.110.214.113]) by smtp.gmail.com with ESMTPSA id qo9-20020a170907874900b0078c1e174e11sm3326124ejc.136.2022.11.13.12.29.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Nov 2022 12:29:56 -0800 (PST) Date: Sun, 13 Nov 2022 21:29:52 +0100 From: Bernhard Reutner-Fischer To: Jonathan Wakely via Gcc-patches Cc: rep.dot.nop@gmail.com, Jonathan Wakely , Arsen =?UTF-8?B?QXJzZW5vdmnEhw==?= , "libstdc++" Subject: Re: [PATCH] libstdc++: Fix python/ not making install directories Message-ID: <20221113212952.66bbe897@nbbrfq> In-Reply-To: References: <20221113180527.2907744-1-arsen@aarsen.me> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, 13 Nov 2022 19:42:52 +0000 Jonathan Wakely via Gcc-patches wrote: > On Sun, 13 Nov 2022, 18:06 Arsen Arsenovi=C4=87 via Libstdc++, < > libstdc++@gcc.gnu.org> wrote: =20 >=20 > > I'm unsure why this issue only started manifesting now with how old this > > code is, but this should fix it. > > =20 >=20 > I just pushed a change to how the debug build makefiles are generated, > which presumably uncovered this latent bug. I'll review the patch in the > morning. Ah, you removed debugdir everywhere but in the install-debug rule :) I.e.: $ git diff diff --git a/libstdc++-v3/src/Makefile.am b/libstdc++-v3/src/Makefile.am index b545ebf0dcf..bfa031ea395 100644 --- a/libstdc++-v3/src/Makefile.am +++ b/libstdc++-v3/src/Makefile.am @@ -422,5 +422,5 @@ build-debug: stamp-debug $(debug_backtrace_supported_h) =20 # Install debug library. install-debug: build-debug - (cd ${debugdir} && $(MAKE) CXXFLAGS=3D'$(DEBUG_FLAGS)' \ - toolexeclibdir=3D$(glibcxx_toolexeclibdir)/debug install) ; + $(MAKE) -C debug CXXFLAGS=3D'$(DEBUG_FLAGS)' \ + toolexeclibdir=3D$(glibcxx_toolexeclibdir)/debug install diff --git a/libstdc++-v3/src/Makefile.in b/libstdc++-v3/src/Makefile.in index f54ee282fb0..8479d297389 100644 --- a/libstdc++-v3/src/Makefile.in +++ b/libstdc++-v3/src/Makefile.in @@ -1142,8 +1142,8 @@ build-debug: stamp-debug $(debug_backtrace_supported_= h) =20 # Install debug library. install-debug: build-debug - (cd ${debugdir} && $(MAKE) CXXFLAGS=3D'$(DEBUG_FLAGS)' \ - toolexeclibdir=3D$(glibcxx_toolexeclibdir)/debug install) ; + $(MAKE) -C debug CXXFLAGS=3D'$(DEBUG_FLAGS)' \ + toolexeclibdir=3D$(glibcxx_toolexeclibdir)/debug install =20 # Tell versions [3.59,3.63) of GNU make to not export all variables. # Otherwise a system limit (for SysV at least) may be exceeded. I personally did not experience the gdb.py install bug Arsen seems to have encountered though. thanks! >=20 >=20 >=20 > > libstdc++-v3/ChangeLog: > > > > * python/Makefile.am: Call mkinstalldirs before INSTALL_DATA > > when installing gdb scripts. > > * python/Makefile.in: Regenerate. > > --- > > Hi, > > > > Someone spotted on IRC spotted an error: if trying to install to a fresh > > prefix/sysroot with --enable-libstdcxx-debug, the install fails since i= t's > > intended target directories don't exist. I could replicate this on > > r13-3944-g43435c7eb0ff60 using > > > > $ ../gcc/configure --disable-bootstrap \ > > --enable-libstdcxx-debug \ > > --enable-languages=3Dc,c++ \ > > --prefix=3D$(pwd)/pfx