public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Iain Sandoe <iains.gcc@gmail.com>
To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: [PATCH] libstdc++: Test for tzdata.zi before fallback version files.
Date: Sat, 24 Dec 2022 11:40:09 +0000	[thread overview]
Message-ID: <20221224114009.20261-1-iain@sandoe.co.uk> (raw)

I tested this (along with the other posted patches for zoneinfo) using
an installation built from the 2022g release on x86_64-darwin21.  Wider
testing will follow.  If we are in an installation without the tzdata.zi
then although we'll report the version OK, the available functionality
will be basic.

OK for trunk?
Iain

--- 8< ---

Several systems/distributions do not provide the raw tzdata.zi file in
their zoneinfo installation.  However, we might provide an alternate
installation path at configure time, so that we should check for the
tzdata.zi file first and then fall back to system-specific files like
+VERSION etc. on those systems.

Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

libstdc++-v3/ChangeLog:

	* src/c++20/tzdb.cc (remote_version): Look for the tzdata.zi
	file before falling back to system-specific ones on Darwin and
	BSD.
---
 libstdc++-v3/src/c++20/tzdb.cc | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/libstdc++-v3/src/c++20/tzdb.cc b/libstdc++-v3/src/c++20/tzdb.cc
index c4311d0902a..39e4466f932 100644
--- a/libstdc++-v3/src/c++20/tzdb.cc
+++ b/libstdc++-v3/src/c++20/tzdb.cc
@@ -1061,16 +1061,11 @@ namespace std::chrono
   namespace
   {
     // Read the version number from a tzdata.zi file.
+    // Note that some systems do not have this file available by default
+    // but we can configure the library to point to an alternate installation.
     string
     remote_version(istream* zif)
     {
-#if defined __NetBSD__
-    if (string ver; ifstream(zoneinfo_dir() + "/TZDATA_VERSION") >> ver)
-      return ver;
-#elif defined __APPLE__
-    if (string ver; ifstream(zoneinfo_dir() + "/+VERSION") >> ver)
-      return ver;
-#else
       ifstream f;
       if (!zif)
 	{
@@ -1083,6 +1078,14 @@ namespace std::chrono
       if (*zif >> hash >> label >> version)
 	if (hash == '#' && label == "version")
 	  return version;
+#if defined __NetBSD__
+    if (string ver; ifstream(zoneinfo_dir() + "/TZDATA_VERSION") >> ver)
+      return ver;
+#elif defined __APPLE__
+    // The standard install on macOS has no tzdata.zi, but we can find the
+    // version from +VERSION.
+    if (string ver; ifstream(zoneinfo_dir() + "/+VERSION") >> ver)
+      return ver;
 #endif
       __throw_runtime_error("tzdb: no version found in tzdata.zi");
     }
-- 
2.37.1 (Apple Git-137.1)


             reply	other threads:[~2022-12-24 11:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-24 11:40 Iain Sandoe [this message]
2022-12-24 12:03 ` Jonathan Wakely
2022-12-24 12:25 ` Andreas Schwab
2022-12-24 17:52   ` Iain Sandoe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221224114009.20261-1-iain@sandoe.co.uk \
    --to=iains.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iain@sandoe.co.uk \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).