public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] libstdc++, testsuite: Correct an init.
@ 2022-12-24 11:42 Iain Sandoe
  2022-12-24 12:07 ` Jonathan Wakely
  0 siblings, 1 reply; 2+ messages in thread
From: Iain Sandoe @ 2022-12-24 11:42 UTC (permalink / raw)
  To: libstdc++, gcc-patches

Noticed while debugging tz info support on Darwin, unless I miss
some other reasoning...
OK for trunk?
Iain

--- 8< ---

in leap_seconds.cc, we are testing to see if the function that
overrides the default zoneinfo directory has been called.  That
is implemented with a static boolean that needs to be initialized
to false.

Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

libstdc++-v3/ChangeLog:

	* testsuite/std/time/tzdb/leap_seconds.cc: Initialize the
	override_used test var to false.
---
 libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc b/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
index 82303e8bdf0..2b289436583 100644
--- a/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
+++ b/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
@@ -7,7 +7,7 @@
 #include <fstream>
 #include <testsuite_hooks.h>
 
-static bool override_used = true;
+static bool override_used = false;
 
 namespace __gnu_cxx
 {
-- 
2.37.1 (Apple Git-137.1)


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] libstdc++, testsuite: Correct an init.
  2022-12-24 11:42 [PATCH] libstdc++, testsuite: Correct an init Iain Sandoe
@ 2022-12-24 12:07 ` Jonathan Wakely
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Wakely @ 2022-12-24 12:07 UTC (permalink / raw)
  To: Iain Sandoe; +Cc: libstdc++, gcc-patches, Iain Sandoe

[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]

On Sat, 24 Dec 2022, 11:43 Iain Sandoe via Libstdc++, <libstdc++@gcc.gnu.org>
wrote:

> Noticed while debugging tz info support on Darwin, unless I miss
> some other reasoning...
> OK for trunk?
>

Doh, thanks. OK for trunk.


Iain
>
> --- 8< ---
>
> in leap_seconds.cc, we are testing to see if the function that
> overrides the default zoneinfo directory has been called.  That
> is implemented with a static boolean that needs to be initialized
> to false.
>
> Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
>
> libstdc++-v3/ChangeLog:
>
>         * testsuite/std/time/tzdb/leap_seconds.cc: Initialize the
>         override_used test var to false.
> ---
>  libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
> b/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
> index 82303e8bdf0..2b289436583 100644
> --- a/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
> +++ b/libstdc++-v3/testsuite/std/time/tzdb/leap_seconds.cc
> @@ -7,7 +7,7 @@
>  #include <fstream>
>  #include <testsuite_hooks.h>
>
> -static bool override_used = true;
> +static bool override_used = false;
>
>  namespace __gnu_cxx
>  {
> --
> 2.37.1 (Apple Git-137.1)
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-12-24 12:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-24 11:42 [PATCH] libstdc++, testsuite: Correct an init Iain Sandoe
2022-12-24 12:07 ` Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).