public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: [committed] libstdc++: Fix configuration of default zoneinfo dir on linux
Date: Tue, 17 Jan 2023 14:18:40 +0000	[thread overview]
Message-ID: <20230117141840.172815-1-jwakely@redhat.com> (raw)

Tested x86_64-linux. Pushed to trunk.

-- >8 --

The config for --with-libstdcxx-zoneinfo=yes was comparing the target
triplet to "gnu* | linux* | kfreebsd*-gnu | knetbsd*-gnu" which is only
the last component of the triplet, so failed to match and always used
the zoneinfo_dir=none default. Check $target_os instead.

There was also an error in the check for native builds that tzdata.zi is
actually present in the configured directory. That meant a warning was
printed even when the file was present:

configure: zoneinfo data directory: /usr/share/zoneinfo
configure: WARNING: "/usr/share/zoneinfo does not contain tzdata.zi file"
configure: static tzdata.zi file will be compiled into the library

libstdc++-v3/ChangeLog:

	* acinclude.m4 (GLIBCXX_ZONEINFO_DIR): Check $target_os instead
	of $host. Fix check for file being present during native build.
	* configure: Regenerate.
---
 libstdc++-v3/acinclude.m4 | 8 ++++----
 libstdc++-v3/configure    | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/libstdc++-v3/acinclude.m4 b/libstdc++-v3/acinclude.m4
index b1608ae9237..982e979a840 100644
--- a/libstdc++-v3/acinclude.m4
+++ b/libstdc++-v3/acinclude.m4
@@ -5180,17 +5180,17 @@ AC_DEFUN([GLIBCXX_ZONEINFO_DIR], [
 
   if test "x${with_libstdcxx_zoneinfo}" = xyes; then
     # Pick a default when no specific path is set.
-    case "$host" in
+    case "$target_os" in
       gnu* | linux* | kfreebsd*-gnu | knetbsd*-gnu)
 	# Not all distros ship tzdata.zi in this dir.
 	zoneinfo_dir="/usr/share/zoneinfo"
 	;;
-      *-*-aix*)
+      aix*)
 	# Binary tzfile files are in /usr/share/lib/zoneinfo
 	# but tzdata.zi is not present there.
 	zoneinfo_dir=none
 	;;
-      *-*-darwin2*)
+      darwin2*)
 	# Binary tzfile files are in /usr/share/lib/zoneinfo.default
 	# but tzdata.zi is not present there.
 	zoneinfo_dir=none
@@ -5230,7 +5230,7 @@ AC_DEFUN([GLIBCXX_ZONEINFO_DIR], [
   if test "x${zoneinfo_dir}" != xnone; then
     AC_DEFINE_UNQUOTED(_GLIBCXX_ZONEINFO_DIR, "${zoneinfo_dir}",
       [Define if a directory should be searched for tzdata files.])
-    if $GLIBCXX_IS_NATIVE -a ! test -f "$zoneinfo_dir/tzdata.zi"; then
+    if $GLIBCXX_IS_NATIVE && ! test -f "$zoneinfo_dir/tzdata.zi"; then
       AC_MSG_WARN("$zoneinfo_dir does not contain tzdata.zi file")
     fi
   fi
diff --git a/libstdc++-v3/configure b/libstdc++-v3/configure
index 9c0f3a3e7c9..a298cbd45a0 100755
--- a/libstdc++-v3/configure
+++ b/libstdc++-v3/configure
@@ -71536,17 +71536,17 @@ fi
 
   if test "x${with_libstdcxx_zoneinfo}" = xyes; then
     # Pick a default when no specific path is set.
-    case "$host" in
+    case "$target_os" in
       gnu* | linux* | kfreebsd*-gnu | knetbsd*-gnu)
 	# Not all distros ship tzdata.zi in this dir.
 	zoneinfo_dir="/usr/share/zoneinfo"
 	;;
-      *-*-aix*)
+      aix*)
 	# Binary tzfile files are in /usr/share/lib/zoneinfo
 	# but tzdata.zi is not present there.
 	zoneinfo_dir=none
 	;;
-      *-*-darwin2*)
+      darwin2*)
 	# Binary tzfile files are in /usr/share/lib/zoneinfo.default
 	# but tzdata.zi is not present there.
 	zoneinfo_dir=none
@@ -71590,7 +71590,7 @@ cat >>confdefs.h <<_ACEOF
 #define _GLIBCXX_ZONEINFO_DIR "${zoneinfo_dir}"
 _ACEOF
 
-    if $GLIBCXX_IS_NATIVE -a ! test -f "$zoneinfo_dir/tzdata.zi"; then
+    if $GLIBCXX_IS_NATIVE && ! test -f "$zoneinfo_dir/tzdata.zi"; then
       { $as_echo "$as_me:${as_lineno-$LINENO}: WARNING: \"$zoneinfo_dir does not contain tzdata.zi file\"" >&5
 $as_echo "$as_me: WARNING: \"$zoneinfo_dir does not contain tzdata.zi file\"" >&2;}
     fi
-- 
2.39.0


                 reply	other threads:[~2023-01-17 14:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230117141840.172815-1-jwakely@redhat.com \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).