From: Jonathan Wakely <jwakely@redhat.com>
To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: [committed] libstdc++: Fix strings read from /etc/sysconfig/clock [PR108530]
Date: Thu, 26 Jan 2023 13:39:01 +0000 [thread overview]
Message-ID: <20230126133901.1428898-1-jwakely@redhat.com> (raw)
Tested x86_64-linux (Fedora 36 and RHEL 6.10). Pushed to trunk.
-- >8 --
In r13-5339-ge00d5cafbe1a77 I made std::chrono::current_zone() look for
DEFAULT_TIMEZONE in /etc/sysconfig/clock but that is the wrong variable.
Old Suse systems use TIMEZONE to determine which zone /etc/localtime is
a copy of, and old RHEL system use ZONE.
libstdc++-v3/ChangeLog:
PR libstdc++/108530
* src/c++20/tzdb.cc (current_zone): Look for TIMEZONE or ZONE in
/etc/sysconfig/clock, not DEFAULT_TIMEZONE.
---
libstdc++-v3/src/c++20/tzdb.cc | 30 ++++++++++++++++--------------
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/libstdc++-v3/src/c++20/tzdb.cc b/libstdc++-v3/src/c++20/tzdb.cc
index eb68111e444..c945f002ad7 100644
--- a/libstdc++-v3/src/c++20/tzdb.cc
+++ b/libstdc++-v3/src/c++20/tzdb.cc
@@ -1667,21 +1667,23 @@ namespace std::chrono
if (ifstream tzf{"/etc/sysconfig/clock"})
{
string line;
- string_view key = "DEFAULT_TIMEZONE=";
+ // Old versions of Suse use TIMEZONE. Old versions of RHEL use ZONE.
+ const string_view keys[] = { "TIMEZONE=" , "ZONE=" };
while (std::getline(tzf, line))
- if (line.starts_with(key))
- {
- string_view name = line;
- name.remove_prefix(key.size());
- if (name.size() != 0 && name.front() == '"')
- {
- name.remove_prefix(1);
- if (auto pos = name.find('"'); pos != name.npos)
- name = name.substr(0, pos);
- }
- if (auto tz = do_locate_zone(this->zones, this->links, name))
- return tz;
- }
+ for (string_view key : keys)
+ if (line.starts_with(key))
+ {
+ string_view name = line;
+ name.remove_prefix(key.size());
+ if (name.size() != 0 && name.front() == '"')
+ {
+ name.remove_prefix(1);
+ if (auto pos = name.find('"'); pos != name.npos)
+ name = name.substr(0, pos);
+ }
+ if (auto tz = do_locate_zone(this->zones, this->links, name))
+ return tz;
+ }
}
#else
// AIX stores current zone in $TZ in /etc/environment but the value
--
2.39.1
reply other threads:[~2023-01-26 13:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126133901.1428898-1-jwakely@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).