From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=/Sc9=55=axis.com=Hans-Peter.Nilsson@sourceware.org>
Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18])
	by sourceware.org (Postfix) with ESMTPS id B3017385841A;
	Wed,  1 Feb 2023 22:37:04 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B3017385841A
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=axis.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=axis.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
  d=axis.com; q=dns/txt; s=axis-central1; t=1675291025;
  x=1706827025;
  h=from:to:cc:in-reply-to:subject:mime-version:
   content-transfer-encoding:references:message-id:date;
  bh=58wAkHPH1pmU4H8yZBu835wydBot6QJr2Jyam3cBRmc=;
  b=pASOxf/sVoxI7TIB6aBTkuZ9mrh9rrKhtcKjsaw9OT5b9gmmEJjvXoZ4
   zZsx9XFTSLbAQt6RC5mJKCdYjbr7utifNFkbYko9r/e8xEoqkOseHXX6p
   6R8vCTlDpMsSg017iPEnBv/9/ZeIvkW0+pNdxxd/LY1MtiEadkhQfywnf
   1VZkKE84LOzgMmvAsEcHS+VHmo75I2p8JpEw3GR8GwZ/vtdnnnD8HTK5G
   iYyahyY28Zn3j+SpFy7WPS0XCoBkNneF14CrZ1PxdT6FmiuJzJJjvHEhn
   bl2Jj+uo7LaKHBZ4nkhF1IXXEQw2SVKj8rmAd+c0UL9ijOwCuwc5Opbgi
   w==;
From: Hans-Peter Nilsson <hp@axis.com>
To: Jonathan Wakely <jwakely@redhat.com>
CC: <libstdc++@gcc.gnu.org>, <gcc-patches@gcc.gnu.org>
In-Reply-To: <CACb0b4kMUb299O=OjQ2z1TmOurqbq7C6TsWGy9WdbHxyv31bhg@mail.gmail.com>
	(message from Jonathan Wakely on Wed, 1 Feb 2023 18:19:09 +0100)
Subject: Re: [PATCH] libstdc++ testsuite: Correct S0 in std/time/hh_mm_ss/1.cc
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
References: <20230201143831.BDA3A20423@pchp3.se.axis.com>
 <CACb0b4na6r1FL1VGe_RYUDYEZeffOv67NnwGHpNKkBC8nLG5-Q@mail.gmail.com> 
	<CACb0b4kMUb299O=OjQ2z1TmOurqbq7C6TsWGy9WdbHxyv31bhg@mail.gmail.com>
Message-ID: <20230201223700.85A2720430@pchp3.se.axis.com>
Date: Wed, 1 Feb 2023 23:37:00 +0100
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libstdc++.gcc.gnu.org>

> From: Jonathan Wakely <jwakely@redhat.com>
> Date: Wed, 1 Feb 2023 18:19:09 +0100

> On Wed, 1 Feb 2023 at 16:01, Jonathan Wakely wrote:
> >
> > On Wed, 1 Feb 2023 at 14:38, Hans-Peter Nilsson via Libstdc++
> > <libstdc++@gcc.gnu.org> wrote:
> > >
> > > Tested cris-elf and native x86_64-pc-linux-gnu.
> > > Ok to commit?
> >
> > OK, thanks.
> 
> We could add the [[no_unique_address]] attribute to the _M_ss member,
> so that it takes no space when it's an empty struct.
> 
> That would save a byte in hh_mm_ss for cris-elf and targets like that,
> but as this type isn't meant to be used for storage, I don't think we
> should bother. People shouldn't be using this as a data member, just
> creating it on the stack and then discarding it.
> 

Agreed; no worries.  Thanks for the review.

brgds, H-P